language-servers/deno
1
0
Fork 0
mirror of https://github.com/denoland/deno.git synced 2025-10-01 06:31:15 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 4

fix(std/node): Stop callbacks being called twice when callback throws error (#8867)

Browse source
This commit is contained in:
Liam Murphy 2021-01-26 23:34:40 +11:00 • committed by GitHub
parent f9949a3170
commit 06bd692e5c
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
46 changed files with 603 additions and 178 deletions
Download patch file Download diff file Expand all files Collapse all files

31
std/node/_crypto/randomBytes_test.ts
View file

@ -1,4 +1,11 @@
import { assert, assertEquals, assertThrows } from "../../testing/asserts.ts";
import {
assert,
assertEquals,
assertStringIncludes,
assertThrows,
assertThrowsAsync,
} from "../../testing/asserts.ts";
import { assertCallbackErrorUncaught } from "../_utils.ts";
import randomBytes, { MAX_RANDOM_VALUES, MAX_SIZE } from "./randomBytes.ts";
Deno.test("randomBytes sync works correctly", function () {
@ -59,10 +66,24 @@ Deno.test("randomBytes async works correctly", function () {
assert(!err);
})
);
assertThrows(() =>
randomBytes(-1, function (err) {
//Shouldn't throw async
assert(!err);
assertThrowsAsync(() =>
new Promise((resolve, reject) => {
randomBytes(-1, function (err, res) {
//Shouldn't throw async
if (err) {
reject(err);
} else {
resolve(res);
}
});
})
);
});
Deno.test("[std/node/crypto] randomBytes callback isn't called twice if error is thrown", async () => {
const importUrl = new URL("./randomBytes.ts", import.meta.url);
await assertCallbackErrorUncaught({
prelude: `import randomBytes from ${JSON.stringify(importUrl)}`,
invocation: "randomBytes(0, ",
});
});