language-servers/deno
1
0
Fork 0
mirror of https://github.com/denoland/deno.git synced 2025-10-01 22:51:14 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

fix(std/node): Stop callbacks being called twice when callback throws error (#8867)

Browse source
This commit is contained in:
Liam Murphy 2021-01-26 23:34:40 +11:00 • committed by GitHub
parent f9949a3170
commit 06bd692e5c
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
46 changed files with 603 additions and 178 deletions
Download patch file Download diff file Expand all files Collapse all files

20
std/node/_fs/_fs_chmod_test.ts
View file

@ -1,5 +1,6 @@
// Copyright 2018-2021 the Deno authors. All rights reserved. MIT license.
import { assert, fail } from "../../testing/asserts.ts";
import { assertCallbackErrorUncaught } from "../_utils.ts";
import { chmod, chmodSync } from "./_fs_chmod.ts";
Deno.test({
@ -18,8 +19,7 @@ Deno.test({
const newFileMode: number | null = Deno.lstatSync(tempFile).mode;
assert(newFileMode && originalFileMode);
assert(newFileMode === 33279 && newFileMode > originalFileMode);
})
.catch(() => {
}, () => {
fail();
})
.finally(() => {
@ -42,3 +42,19 @@ Deno.test({
Deno.removeSync(tempFile);
},
});
Deno.test({
name: "[std/node/fs] chmod callback isn't called twice if error is thrown",
ignore: Deno.build.os === "windows",
async fn() {
const tempFile = await Deno.makeTempFile();
const importUrl = new URL("./_fs_chmod.ts", import.meta.url);
await assertCallbackErrorUncaught({
prelude: `import { chmod } from ${JSON.stringify(importUrl)}`,
invocation: `chmod(${JSON.stringify(tempFile)}, 0o777, `,
async cleanup() {
await Deno.remove(tempFile);
},
});
},
});