language-servers/deno
1
0
Fork 0
mirror of https://github.com/denoland/deno.git synced 2025-10-02 15:14:33 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

fix(std/node): Stop callbacks being called twice when callback throws error (#8867)

Browse source
This commit is contained in:
Liam Murphy 2021-01-26 23:34:40 +11:00 • committed by GitHub
parent f9949a3170
commit 06bd692e5c
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
46 changed files with 603 additions and 178 deletions
Download patch file Download diff file Expand all files Collapse all files

33
std/node/_fs/_fs_dir_test.ts
View file

@ -1,5 +1,6 @@
// Copyright 2018-2021 the Deno authors. All rights reserved. MIT license.
import { assert, assertEquals, fail } from "../../testing/asserts.ts";
import { assertCallbackErrorUncaught } from "../_utils.ts";
import Dir from "./_fs_dir.ts";
import type Dirent from "./_fs_dirent.ts";
@ -165,3 +166,35 @@ Deno.test({
}
},
});
Deno.test("[std/node/fs] Dir.close callback isn't called twice if error is thrown", async () => {
const tempDir = await Deno.makeTempDir();
const importUrl = new URL("./_fs_dir.ts", import.meta.url);
await assertCallbackErrorUncaught({
prelude: `
import Dir from ${JSON.stringify(importUrl)};
const dir = new Dir(${JSON.stringify(tempDir)});
`,
invocation: "dir.close(",
async cleanup() {
await Deno.remove(tempDir);
},
});
});
Deno.test("[std/node/fs] Dir.read callback isn't called twice if error is thrown", async () => {
const tempDir = await Deno.makeTempDir();
const importUrl = new URL("./_fs_dir.ts", import.meta.url);
await assertCallbackErrorUncaught({
prelude: `
import Dir from ${JSON.stringify(importUrl)};
const dir = new Dir(${JSON.stringify(tempDir)});
`,
invocation: "dir.read(",
async cleanup() {
await Deno.remove(tempDir);
},
});
});