language-servers/deno
1
0
Fork 0
mirror of https://github.com/denoland/deno.git synced 2025-10-02 15:14:33 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

fix(std/node): Stop callbacks being called twice when callback throws error (#8867)

Browse source
This commit is contained in:
Liam Murphy 2021-01-26 23:34:40 +11:00 • committed by GitHub
parent f9949a3170
commit 06bd692e5c
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
46 changed files with 603 additions and 178 deletions
Download patch file Download diff file Expand all files Collapse all files

16
std/node/_fs/_fs_open_test.ts
View file

@ -4,6 +4,7 @@ import {
assertThrows,
fail,
} from "../../testing/asserts.ts";
import { assertCallbackErrorUncaught } from "../_utils.ts";
import { open, openSync } from "./_fs_open.ts";
import { join, parse } from "../../path/mod.ts";
import { existsSync } from "../../fs/mod.ts";
@ -25,8 +26,7 @@ Deno.test({
.then((fd) => {
fd1 = fd;
assert(Deno.resources()[fd], `${fd}`);
})
.catch(() => fail())
}, () => fail())
.finally(() => closeSync(fd1));
},
});
@ -207,3 +207,15 @@ Deno.test({
Deno.removeSync(file);
},
});
Deno.test("[std/node/fs] open callback isn't called twice if error is thrown", async () => {
const tempFile = await Deno.makeTempFile();
const importUrl = new URL("./_fs_open.ts", import.meta.url);
await assertCallbackErrorUncaught({
prelude: `import { open } from ${JSON.stringify(importUrl)}`,
invocation: `open(${JSON.stringify(tempFile)}, `,
async cleanup() {
await Deno.remove(tempFile);
},
});
});