language-servers/deno
1
0
Fork 0
mirror of https://github.com/denoland/deno.git synced 2025-10-01 06:31:15 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 4

fix(std/node): Stop callbacks being called twice when callback throws error (#8867)

Browse source
This commit is contained in:
Liam Murphy 2021-01-26 23:34:40 +11:00 • committed by GitHub
parent f9949a3170
commit 06bd692e5c
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
46 changed files with 603 additions and 178 deletions
Download patch file Download diff file Expand all files Collapse all files

13
std/node/_fs/_fs_readFile_test.ts
View file

@ -1,4 +1,5 @@
// Copyright 2018-2021 the Deno authors. All rights reserved. MIT license.
import { assertCallbackErrorUncaught } from "../_utils.ts";
import { readFile, readFileSync } from "./_fs_readFile.ts";
import * as path from "../../path/mod.ts";
import { assert, assertEquals } from "../../testing/asserts.ts";
@ -103,3 +104,15 @@ Deno.test("readFileEncodeAsString", function () {
assertEquals(typeof data, "string");
assertEquals(data as string, "hello world");
});
Deno.test("[std/node/fs] readFile callback isn't called twice if error is thrown", async () => {
const tempFile = await Deno.makeTempFile();
const importUrl = new URL("./_fs_readFile.ts", import.meta.url);
await assertCallbackErrorUncaught({
prelude: `import { readFile } from ${JSON.stringify(importUrl)}`,
invocation: `readFile(${JSON.stringify(tempFile)}, `,
async cleanup() {
await Deno.remove(tempFile);
},
});
});