language-servers/deno
1
0
Fork 0
mirror of https://github.com/denoland/deno.git synced 2025-10-01 22:51:14 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

fix(std/node): Stop callbacks being called twice when callback throws error (#8867)

Browse source
This commit is contained in:
Liam Murphy 2021-01-26 23:34:40 +11:00 • committed by GitHub
parent f9949a3170
commit 06bd692e5c
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
46 changed files with 603 additions and 178 deletions
Download patch file Download diff file Expand all files Collapse all files

22
std/node/_fs/_fs_stat_test.ts
View file

@ -1,3 +1,4 @@
import { assertCallbackErrorUncaught } from "../_utils.ts";
import { BigIntStats, stat, Stats, statSync } from "./_fs_stat.ts";
import { assertEquals, fail } from "../../testing/asserts.ts";
@ -68,8 +69,7 @@ Deno.test({
resolve(stat);
});
})
.then((stat) => assertStats(stat, Deno.statSync(file)))
.catch(() => fail())
.then((stat) => assertStats(stat, Deno.statSync(file)), () => fail())
.finally(() => Deno.removeSync(file));
},
});
@ -92,8 +92,10 @@ Deno.test({
resolve(stat);
});
})
.then((stat) => assertStatsBigInt(stat, Deno.statSync(file)))
.catch(() => fail())
.then(
(stat) => assertStatsBigInt(stat, Deno.statSync(file)),
() => fail(),
)
.finally(() => Deno.removeSync(file));
},
});
@ -105,3 +107,15 @@ Deno.test({
assertStatsBigInt(statSync(file, { bigint: true }), Deno.statSync(file));
},
});
Deno.test("[std/node/fs] stat callback isn't called twice if error is thrown", async () => {
const tempFile = await Deno.makeTempFile();
const importUrl = new URL("./_fs_stat.ts", import.meta.url);
await assertCallbackErrorUncaught({
prelude: `import { stat } from ${JSON.stringify(importUrl)}`,
invocation: `stat(${JSON.stringify(tempFile)}, `,
async cleanup() {
await Deno.remove(tempFile);
},
});
});