language-servers/deno
1
0
Fork 0
mirror of https://github.com/denoland/deno.git synced 2025-08-03 10:33:54 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

BREAKING(config): make supported compilerOptions an allow list (#25432)

Browse source 
Deno has been using a deny list, which doesn't make sense because a lot
of these options don't even work.

Closes #25363
This commit is contained in:
David Sherret 2024-09-04 17:39:30 +02:00 • committed by GitHub
parent 5400f1af6c
commit 07ad47da53
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
17 changed files with 36 additions and 39 deletions
Download patch file Download diff file Expand all files Collapse all files

8
cli/lsp/config.rs
View file

@ -1387,10 +1387,8 @@ impl ConfigData {
}
}
let node_modules_dir = member_dir
.workspace
.node_modules_dir_mode()
.unwrap_or_default();
let node_modules_dir =
member_dir.workspace.node_modules_dir().unwrap_or_default();
let byonm = match node_modules_dir {
Some(mode) => mode == NodeModulesDirMode::Manual,
None => member_dir.workspace.root_pkg_json().is_some(),
@ -1873,7 +1871,7 @@ fn resolve_node_modules_dir(
// `nodeModulesDir: true` setting in the deno.json file. This is to
// reduce the chance of modifying someone's node_modules directory
// without them having asked us to do so.
let node_modules_mode = workspace.node_modules_dir_mode().ok().flatten();
let node_modules_mode = workspace.node_modules_dir().ok().flatten();
let explicitly_disabled = node_modules_mode == Some(NodeModulesDirMode::None);
if explicitly_disabled {
return None;