fix(node_resolver): incorrect resolution of require("..") (#30524)

Fixes https://github.com/denoland/deno/issues/30505

libs/node_resolver/resolution.rs

@@ -553,10 +553,9 @@ impl<
     // }
 
     let p_str = path.to_str().unwrap();
-    let path = if p_str.ends_with('/') {
-      PathBuf::from(&p_str[p_str.len() - 1..])
-    } else {
-      path
+    let path = match p_str.strip_suffix('/') {
+      Some(s) => Cow::Borrowed(Path::new(s)),
+      None => Cow::Owned(path),
     };
 
     let maybe_file_type = self.sys.get_file_type(&path);
@@ -570,7 +569,7 @@ impl<
             .find(|e| self.sys.is_file(&path.join(e)));
           Err(
             UnsupportedDirImportError {
-              dir_url: UrlOrPath::Path(path),
+              dir_url: UrlOrPath::Path(path.into_owned()),
               maybe_referrer: maybe_referrer.map(|r| r.display()),
               suggested_file_name,
             }
@@ -607,7 +606,7 @@ impl<
         Ok(
           maybe_url
             .map(UrlOrPath::Url)
-            .unwrap_or(UrlOrPath::Path(path)),
+            .unwrap_or(UrlOrPath::Path(path.into_owned())),
         )
       }
       _ => {
@@ -626,7 +625,7 @@ impl<
           ModuleNotFoundError {
             suggested_ext: self
               .module_not_found_ext_suggestion(&path, resolved_method),
-            specifier: UrlOrPath::Path(path),
+            specifier: UrlOrPath::Path(path.into_owned()),
             maybe_referrer: maybe_referrer.map(|r| r.display()),
           }
           .into(),

tests/specs/bundle/require_dotdot/__test__.jsonc

@@ -0,0 +1,13 @@
+{
+  "tempDir": true,
+  "steps": [
+    {
+      "args": "bundle -o out.js ./repro/foo.cjs",
+      "output": "[WILDCARD]"
+    },
+    {
+      "args": "run -A out.js",
+      "output": "hello from index\n"
+    }
+  ]
+}

tests/specs/bundle/require_dotdot/index.js

@@ -0,0 +1 @@
+module.exports = "hello from index";

tests/specs/bundle/require_dotdot/package.json

@@ -0,0 +1 @@
+{}

tests/specs/bundle/require_dotdot/repro/foo.cjs

@@ -0,0 +1,2 @@
+const index = require("..");
+console.log(index);