language-servers/deno
1
0
Fork 0
mirror of https://github.com/denoland/deno.git synced 2025-08-03 02:22:40 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

refactor(core/js_error): Align JSStackFrame with CallSite (#4715)

Browse source 
Renames and adds missing fields to JSStackFrame from CallSite. Fixes #4705.

Cleans up base changes for line and column numbers.
This commit is contained in:
Nayeem Rahman 2020-04-13 15:54:16 +01:00 • committed by GitHub
parent 5105c68399
commit 0ea6eb83a9
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
13 changed files with 271 additions and 192 deletions
Download patch file Download diff file Expand all files Collapse all files

24
cli/js/ops/errors.ts
View file

@ -7,25 +7,21 @@ export function formatDiagnostics(items: DiagnosticItem[]): string {
}
export interface Location {
filename: string;
line: number;
column: number;
fileName: string;
lineNumber: number;
columnNumber: number;
}
export function applySourceMap(location: Location): Location {
const { filename, line, column } = location;
// On this side, line/column are 1 based, but in the source maps, they are
// 0 based, so we have to convert back and forth
const { fileName, lineNumber, columnNumber } = location;
const res = sendSync("op_apply_source_map", {
filename,
line: line - 1,
column: column - 1,
fileName,
lineNumber: lineNumber,
columnNumber: columnNumber,
});
return {
filename: res.filename,
line: res.line + 1,
column: res.column + 1,
fileName: res.fileName,
lineNumber: res.lineNumber,
columnNumber: res.columnNumber,
};
}