language-servers/deno
1
0
Fork 0
mirror of https://github.com/denoland/deno.git synced 2025-09-27 12:49:10 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

refactor(core/js_error): Align JSStackFrame with CallSite (#4715)

Browse source 
Renames and adds missing fields to JSStackFrame from CallSite. Fixes #4705.

Cleans up base changes for line and column numbers.
This commit is contained in:
Nayeem Rahman 2020-04-13 15:54:16 +01:00 • committed by GitHub
parent 5105c68399
commit 0ea6eb83a9
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
13 changed files with 271 additions and 192 deletions
Download patch file Download diff file Expand all files Collapse all files

36
cli/js/tests/error_stack_test.ts
View file

@ -6,15 +6,15 @@ const { setPrepareStackTrace } = Deno[Deno.symbols.internal];
interface CallSite {
getThis(): unknown;
getTypeName(): string;
getFunction(): Function;
getFunctionName(): string;
getMethodName(): string;
getFileName(): string;
getTypeName(): string | null;
getFunction(): Function | null;
getFunctionName(): string | null;
getMethodName(): string | null;
getFileName(): string | null;
getLineNumber(): number | null;
getColumnNumber(): number | null;
getEvalOrigin(): string | null;
isToplevel(): boolean;
isToplevel(): boolean | null;
isEval(): boolean;
isNative(): boolean;
isConstructor(): boolean;
@ -24,9 +24,9 @@ interface CallSite {
}
function getMockCallSite(
filename: string,
line: number | null,
column: number | null
fileName: string,
lineNumber: number | null,
columnNumber: number | null
): CallSite {
return {
getThis(): unknown {
@ -45,13 +45,13 @@ function getMockCallSite(
return "";
},
getFileName(): string {
return filename;
return fileName;
},
getLineNumber(): number | null {
return line;
return lineNumber;
},
getColumnNumber(): number | null {
return column;
return columnNumber;
},
getEvalOrigin(): null {
return null;
@ -98,11 +98,11 @@ unitTest(function prepareStackTrace(): void {
unitTest(function applySourceMap(): void {
const result = Deno.applySourceMap({
filename: "CLI_SNAPSHOT.js",
line: 23,
column: 0,
fileName: "CLI_SNAPSHOT.js",
lineNumber: 23,
columnNumber: 0,
});
assert(result.filename.endsWith(".ts"));
assert(result.line != null);
assert(result.column != null);
assert(result.fileName.endsWith(".ts"));
assert(result.lineNumber != null);
assert(result.columnNumber != null);
});