From 0ffaaba1648bab0cf8da04bbb9a2e1fac2ac60aa Mon Sep 17 00:00:00 2001 From: Nayeem Rahman Date: Fri, 25 Sep 2020 22:23:35 +0100 Subject: [PATCH] fix(cli/dts): Use var instead of const and let for globals (#7680) --- cli/dts/lib.deno.shared_globals.d.ts | 4 +--- cli/dts/lib.deno.window.d.ts | 8 ++++---- cli/dts/lib.deno.worker.d.ts | 12 ++++++------ cli/tests/types.out | 2 +- op_crates/fetch/lib.deno_fetch.d.ts | 2 +- op_crates/web/lib.deno_web.d.ts | 2 +- 6 files changed, 14 insertions(+), 16 deletions(-) diff --git a/cli/dts/lib.deno.shared_globals.d.ts b/cli/dts/lib.deno.shared_globals.d.ts index 9f40e2521f..9e324258df 100644 --- a/cli/dts/lib.deno.shared_globals.d.ts +++ b/cli/dts/lib.deno.shared_globals.d.ts @@ -222,8 +222,6 @@ interface DOMStringList { type BufferSource = ArrayBufferView | ArrayBuffer; -declare const isConsoleInstance: unique symbol; - declare interface Console { assert(condition?: boolean, ...data: any[]): void; clear(): void; @@ -584,7 +582,7 @@ declare class Performance { now(): number; } -declare const performance: Performance; +declare var performance: Performance; declare interface PerformanceMarkOptions { /** Metadata to be included in the mark. */ diff --git a/cli/dts/lib.deno.window.d.ts b/cli/dts/lib.deno.window.d.ts index 61c5abf8ad..5c113cd0d5 100644 --- a/cli/dts/lib.deno.window.d.ts +++ b/cli/dts/lib.deno.window.d.ts @@ -17,9 +17,9 @@ declare interface Window extends EventTarget { Deno: typeof Deno; } -declare const window: Window & typeof globalThis; -declare const self: Window & typeof globalThis; -declare const onload: ((this: Window, ev: Event) => any) | null; -declare const onunload: ((this: Window, ev: Event) => any) | null; +declare var window: Window & typeof globalThis; +declare var self: Window & typeof globalThis; +declare var onload: ((this: Window, ev: Event) => any) | null; +declare var onunload: ((this: Window, ev: Event) => any) | null; /* eslint-enable @typescript-eslint/no-explicit-any */ diff --git a/cli/dts/lib.deno.worker.d.ts b/cli/dts/lib.deno.worker.d.ts index 95aa161397..9f8845f4ab 100644 --- a/cli/dts/lib.deno.worker.d.ts +++ b/cli/dts/lib.deno.worker.d.ts @@ -18,9 +18,9 @@ declare interface DedicatedWorkerGlobalScope { Deno: typeof Deno; } -declare const self: DedicatedWorkerGlobalScope & typeof globalThis; -declare let onmessage: ((e: { data: any }) => Promise | void) | undefined; -declare let onerror: +declare var self: DedicatedWorkerGlobalScope & typeof globalThis; +declare var onmessage: ((e: { data: any }) => Promise | void) | undefined; +declare var onerror: | (( msg: string, source: string, @@ -29,9 +29,9 @@ declare let onerror: e: Event, ) => boolean | void) | undefined; -declare const close: typeof __workerMain.close; -declare const name: typeof __workerMain.name; -declare const postMessage: typeof __workerMain.postMessage; +declare var close: typeof __workerMain.close; +declare var name: typeof __workerMain.name; +declare var postMessage: typeof __workerMain.postMessage; declare namespace __workerMain { export let onmessage: (e: { data: any }) => void; diff --git a/cli/tests/types.out b/cli/tests/types.out index 85bee7698e..ee59f57c11 100644 --- a/cli/tests/types.out +++ b/cli/tests/types.out @@ -1,4 +1,4 @@ // Copyright 2018-2020 the Deno authors. All rights reserved. MIT license. [WILDCARD] declare namespace Deno [WILDCARD] -declare const window: Window [WILDCARD] +declare var window: Window [WILDCARD] diff --git a/op_crates/fetch/lib.deno_fetch.d.ts b/op_crates/fetch/lib.deno_fetch.d.ts index 6e7edad3f4..4a51bcc956 100644 --- a/op_crates/fetch/lib.deno_fetch.d.ts +++ b/op_crates/fetch/lib.deno_fetch.d.ts @@ -142,7 +142,7 @@ interface ReadableStream { }): AsyncIterableIterator; } -declare const ReadableStream: { +declare var ReadableStream: { prototype: ReadableStream; new ( underlyingSource: UnderlyingByteSource, diff --git a/op_crates/web/lib.deno_web.d.ts b/op_crates/web/lib.deno_web.d.ts index 102fbf7187..4dffe7c48e 100644 --- a/op_crates/web/lib.deno_web.d.ts +++ b/op_crates/web/lib.deno_web.d.ts @@ -231,7 +231,7 @@ interface AbortSignal extends EventTarget { ): void; } -declare const AbortSignal: { +declare var AbortSignal: { prototype: AbortSignal; new (): AbortSignal; };