mirror of
https://github.com/denoland/deno.git
synced 2025-10-01 22:51:14 +00:00
refactor: break up ProcState
(#18707)
1. Breaks up functionality within `ProcState` into several other structs to break out the responsibilities (`ProcState` is only a data struct now). 2. Moves towards being able to inject dependencies more easily and have functionality only require what it needs. 3. Exposes `Arc<T>` around the "service structs" instead of it being embedded within them. The idea behind embedding them was to reduce the verbosity of needing to pass around `Arc<...>`, but I don't think it was exactly working and as we move more of these structs to be more injectable I don't think the extra verbosity will be a big deal.
This commit is contained in:
parent
a411144219
commit
136dce67ce
33 changed files with 1506 additions and 1285 deletions
|
@ -1259,14 +1259,15 @@ pub async fn check_specifiers(
|
|||
ps.file_fetcher.insert_cached(file);
|
||||
}
|
||||
|
||||
ps.prepare_module_load(
|
||||
specifiers,
|
||||
false,
|
||||
lib,
|
||||
PermissionsContainer::new(Permissions::allow_all()),
|
||||
PermissionsContainer::new(permissions.clone()),
|
||||
)
|
||||
.await?;
|
||||
ps.module_load_preparer
|
||||
.prepare_module_load(
|
||||
specifiers,
|
||||
false,
|
||||
lib,
|
||||
PermissionsContainer::new(Permissions::allow_all()),
|
||||
PermissionsContainer::new(permissions.clone()),
|
||||
)
|
||||
.await?;
|
||||
}
|
||||
|
||||
let module_specifiers = specifiers
|
||||
|
@ -1280,14 +1281,15 @@ pub async fn check_specifiers(
|
|||
})
|
||||
.collect();
|
||||
|
||||
ps.prepare_module_load(
|
||||
module_specifiers,
|
||||
false,
|
||||
lib,
|
||||
PermissionsContainer::allow_all(),
|
||||
PermissionsContainer::new(permissions),
|
||||
)
|
||||
.await?;
|
||||
ps.module_load_preparer
|
||||
.prepare_module_load(
|
||||
module_specifiers,
|
||||
false,
|
||||
lib,
|
||||
PermissionsContainer::allow_all(),
|
||||
PermissionsContainer::new(permissions),
|
||||
)
|
||||
.await?;
|
||||
|
||||
Ok(())
|
||||
}
|
||||
|
@ -1708,7 +1710,10 @@ pub async fn run_tests_with_watch(
|
|||
} else {
|
||||
test_modules.clone()
|
||||
};
|
||||
let graph = ps.create_graph(test_modules.clone()).await?;
|
||||
let graph = ps
|
||||
.module_graph_builder
|
||||
.create_graph(test_modules.clone())
|
||||
.await?;
|
||||
graph_valid_with_cli_options(&graph, &test_modules, &ps.options)?;
|
||||
|
||||
// TODO(@kitsonk) - This should be totally derivable from the graph.
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue