fix: don't use public rid accessors in internal APIs (#22091)

Co-authored-by: Asher Gomez <ashersaupingomez@gmail.com>
This commit is contained in:
Bartek Iwańczuk 2024-01-25 00:45:19 +01:00 committed by GitHub
parent a4e64fb7da
commit 174bb70eda
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
4 changed files with 23 additions and 5 deletions

View file

@ -10,6 +10,7 @@ const {
} = core.ensureFastOps();
const {
Number,
SymbolFor,
TypeError,
} = primordials;
@ -24,10 +25,12 @@ function opTlsHandshake(rid) {
}
class TlsConn extends Conn {
[SymbolFor("Deno.internal.rid")] = 0;
#rid = 0;
constructor(rid, remoteAddr, localAddr) {
super(rid, remoteAddr, localAddr);
this[SymbolFor("Deno.internal.rid")] = rid;
this.#rid = rid;
}
@ -75,10 +78,12 @@ async function connectTls({
}
class TlsListener extends Listener {
[SymbolFor("Deno.internal.rid")] = 0;
#rid = 0;
constructor(rid, addr) {
super(rid, addr);
this[SymbolFor("Deno.internal.rid")] = rid;
this.#rid = rid;
}
@ -146,7 +151,7 @@ async function startTls(
} = {},
) {
const { 0: rid, 1: localAddr, 2: remoteAddr } = await opStartTls({
rid: conn.rid,
rid: conn[SymbolFor("Deno.internal.rid")],
hostname,
certFile,
caCerts,