language-servers/deno
1
0
Fork 0
mirror of https://github.com/denoland/deno.git synced 2025-09-26 12:19:12 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

fix(ext/process): suppress child process kill errors in onAbort handler (#29193)

Browse source 
Co-authored-by: Divy Srivastava <dj.srivastava23@gmail.com>
This commit is contained in:
Satya Rohith 2025-05-07 10:56:58 +05:30 • committed by GitHub
parent 8e9db221ed
commit 19c5cca65e
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 25 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

9
ext/process/40_process.js
View file

@ -299,9 +299,14 @@ class ChildProcess {
this.#stderr = readableStreamForRidUnrefable(stderrRid);
}
const onAbort = () => this.kill("SIGTERM");
const onAbort = () => {
try {
this.kill("SIGTERM");
} catch {
// Ignore the error for https://github.com/denoland/deno/issues/27112
}
};
signal?.[abortSignal.add](onAbort);
const waitPromise = op_spawn_wait(this.#rid);
this.#waitPromise = waitPromise;
this.#status = PromisePrototypeThen(waitPromise, (res) => {

18
tests/unit/command_test.ts
View file

@ -1093,3 +1093,21 @@ Deno.test(
assertEquals(child.success, true);
},
);
Deno.test(
{ ignore: Deno.build.os === "windows" },
async function abortChildProcessRightWhenItExitsShouldNotThrow() {
const controller = new AbortController();
const cb = () => controller.abort();
Deno.addSignalListener("SIGCHLD", cb);
const output = await new Deno.Command("true", { signal: controller.signal })
.output();
assertEquals(output.success, true);
assertEquals(output.code, 0);
assertEquals(output.signal, null);
assertEquals(output.stdout, new Uint8Array());
assertEquals(output.stderr, new Uint8Array());
Deno.removeSignalListener("SIGCHLD", cb);
},
);