language-servers/deno
1
0
Fork 0
mirror of https://github.com/denoland/deno.git synced 2025-09-26 12:19:12 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

chore(cli/cache): fewer string allocations (#17549)

Browse source
This commit is contained in:
Geert-Jan Zwiers 2023-01-27 16:16:38 +01:00 • committed by GitHub
parent 7f38f30a5c
commit 1a1faff2f6
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
4 changed files with 7 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

2
cli/cache/check.rs vendored
View file

@ -192,7 +192,7 @@ fn create_tables(
|row| row.get(0), |row| row.get(0),
) )
.ok(); .ok();
if data_cli_version != Some(cli_version.to_string()) { if data_cli_version.as_deref() != Some(&cli_version) {
conn.execute("DELETE FROM checkcache", params![])?; conn.execute("DELETE FROM checkcache", params![])?;
conn.execute("DELETE FROM tsbuildinfo", params![])?; conn.execute("DELETE FROM tsbuildinfo", params![])?;
let mut stmt = conn let mut stmt = conn

4
cli/cache/incremental.rs vendored
View file

@ -232,7 +232,7 @@ impl SqlIncrementalCache {
stmt.execute(params![ stmt.execute(params![
path.to_string_lossy(), path.to_string_lossy(),
&self.state_hash.to_string(), &self.state_hash.to_string(),
&source_hash.to_string(), &source_hash,
])?; ])?;
Ok(()) Ok(())
} }
@ -267,7 +267,7 @@ fn create_tables(
|row| row.get(0), |row| row.get(0),
) )
.ok(); .ok();
if data_cli_version != Some(cli_version.to_string()) { if data_cli_version.as_deref() != Some(&cli_version) {
conn.execute("DELETE FROM incrementalcache", params![])?; conn.execute("DELETE FROM incrementalcache", params![])?;
let mut stmt = conn let mut stmt = conn
.prepare("INSERT OR REPLACE INTO info (key, value) VALUES (?1, ?2)")?; .prepare("INSERT OR REPLACE INTO info (key, value) VALUES (?1, ?2)")?;

4
cli/cache/node.rs vendored
View file

@ -253,7 +253,7 @@ impl NodeAnalysisCacheInner {
let mut stmt = self.conn.prepare_cached(sql)?; let mut stmt = self.conn.prepare_cached(sql)?;
stmt.execute(params![ stmt.execute(params![
specifier, specifier,
&source_hash.to_string(), &source_hash,
&serde_json::to_string(top_level_decls)?, &serde_json::to_string(top_level_decls)?,
])?; ])?;
Ok(()) Ok(())
@ -304,7 +304,7 @@ fn create_tables(conn: &Connection, cli_version: &str) -> Result<(), AnyError> {
|row| row.get(0), |row| row.get(0),
) )
.ok(); .ok();
if data_cli_version != Some(cli_version.to_string()) { if data_cli_version.as_deref() != Some(cli_version) {
conn.execute("DELETE FROM cjsanalysiscache", params![])?; conn.execute("DELETE FROM cjsanalysiscache", params![])?;
conn.execute("DELETE FROM esmglobalscache", params![])?; conn.execute("DELETE FROM esmglobalscache", params![])?;
let mut stmt = conn let mut stmt = conn

4
cli/cache/parsed_source.rs vendored
View file

@ -219,7 +219,7 @@ impl ParsedSourceCacheModuleAnalyzer {
stmt.execute(params![ stmt.execute(params![
specifier.as_str(), specifier.as_str(),
&media_type.to_string(), &media_type.to_string(),
&source_hash.to_string(), &source_hash,
&serde_json::to_string(&module_info)?, &serde_json::to_string(&module_info)?,
])?; ])?;
Ok(()) Ok(())
@ -298,7 +298,7 @@ fn create_tables(
|row| row.get(0), |row| row.get(0),
) )
.ok(); .ok();
if data_cli_version != Some(cli_version.to_string()) { if data_cli_version.as_deref() != Some(&cli_version) {
conn.execute("DELETE FROM moduleinfocache", params![])?; conn.execute("DELETE FROM moduleinfocache", params![])?;
let mut stmt = conn let mut stmt = conn
.prepare("INSERT OR REPLACE INTO info (key, value) VALUES (?1, ?2)")?; .prepare("INSERT OR REPLACE INTO info (key, value) VALUES (?1, ?2)")?;