language-servers/deno
1
0
Fork 0
mirror of https://github.com/denoland/deno.git synced 2025-08-03 10:33:54 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

perf(ops): Monomorphic sync op calls (#15337)

Browse source 
Welcome to better optimised op calls! Currently opSync is called with parameters of every type and count. This most definitely makes the call megamorphic. Additionally, it seems that spread params leads to V8 not being able to optimise the calls quite as well (apparently Fast Calls cannot be used with spread params).

Monomorphising op calls should lead to some improved performance. Now that unwrapping of sync ops results is done on Rust side, this is pretty simple:

```
opSync("op_foo", param1, param2);
// -> turns to
ops.op_foo(param1, param2);
```

This means sync op calls are now just directly calling the native binding function. When V8 Fast API Calls are enabled, this will enable those to be called on the optimised path.

Monomorphising async ops likely requires using callbacks and is left as an exercise to the reader.
This commit is contained in:
Aapo Alasuutari 2022-08-11 16:56:56 +03:00 • committed by GitHub
parent 883269f1f1
commit 2164f6b1eb
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
80 changed files with 552 additions and 616 deletions
Download patch file Download diff file Expand all files Collapse all files

6
runtime/js/40_files.js
View file

@ -3,6 +3,7 @@
((window) => {
const core = window.Deno.core;
const ops = core.ops;
const { read, readSync, write, writeSync } = window.__bootstrap.io;
const { ftruncate, ftruncateSync, fstat, fstatSync } = window.__bootstrap.fs;
const { pathFromURL } = window.__bootstrap.util;
@ -19,7 +20,7 @@
offset,
whence,
) {
return core.opSync("op_seek_sync", { rid, offset, whence });
return ops.op_seek_sync({ rid, offset, whence });
}
function seek(
@ -36,8 +37,7 @@
) {
checkOpenOptions(options);
const mode = options?.mode;
const rid = core.opSync(
"op_open_sync",
const rid = ops.op_open_sync(
{ path: pathFromURL(path), options, mode },
);