language-servers/deno
1
0
Fork 0
mirror of https://github.com/denoland/deno.git synced 2025-08-03 18:38:33 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

feat(test): format user code output (#14271)

Browse source 
This commit changes "deno test" to better denote user output coming
from test cases.

This is done by printing "---- output ----" and "---- output end ----"
markers if an output is produced. The output from "console" and
"Deno.core.print" is captured, as well as direct writes to "Deno.stdout"
and "Deno.stderr".

To achieve that new APIs were added to "deno_core" crate, that allow
to replace an existing resource with a different one (while keeping resource
ids intact). Resources for stdout and stderr are replaced by pipes.

Co-authored-by: David Sherret <dsherret@gmail.com>
This commit is contained in:
Bartek Iwańczuk 2022-04-15 14:24:41 +02:00 • committed by GitHub
parent 0e4574b2e3
commit 244926e83c
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
10 changed files with 246 additions and 35 deletions
Download patch file Download diff file Expand all files Collapse all files

31
cli/lsp/testing/execution.rs
View file

@ -14,6 +14,7 @@ use crate::lsp::client::TestingNotification;
use crate::lsp::config;
use crate::lsp::logging::lsp_log;
use crate::ops;
use crate::ops::testing::create_stdout_stderr_pipes;
use crate::proc_state;
use crate::tools::test;
@ -183,11 +184,17 @@ async fn test_specifier(
options: Option<Value>,
) -> Result<(), AnyError> {
if !token.is_cancelled() {
let (stdout_writer, stderr_writer) =
create_stdout_stderr_pipes(channel.clone());
let mut worker = create_main_worker(
&ps,
specifier.clone(),
permissions,
vec![ops::testing::init(channel.clone())],
vec![ops::testing::init(
channel.clone(),
stdout_writer,
stderr_writer,
)],
);
worker
@ -752,16 +759,20 @@ impl test::TestReporter for LspTestReporter {
.get(origin)
.and_then(|v| v.last().map(|td| td.into()))
});
match output {
test::TestOutput::Console(value) => {
self.progress(lsp_custom::TestRunProgressMessage::Output {
value: value.replace('\n', "\r\n"),
test,
// TODO(@kitsonk) test output should include a location
location: None,
})
let value = match output {
test::TestOutput::PrintStdout(value)
| test::TestOutput::PrintStderr(value) => value.replace('\n', "\r\n"),
test::TestOutput::Stdout(bytes) | test::TestOutput::Stderr(bytes) => {
String::from_utf8_lossy(bytes).replace('\n', "\r\n")
}
}
};
self.progress(lsp_custom::TestRunProgressMessage::Output {
value,
test,
// TODO(@kitsonk) test output should include a location
location: None,
})
}
fn report_result(