language-servers/deno
1
0
Fork 0
mirror of https://github.com/denoland/deno.git synced 2025-08-04 02:48:24 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

fix(check): attempt to resolve types from pkg before @types pkg (#24152)

Browse source 
I've been meaning to fix this for ages, but I finally ran into it here:


2598132540

We need to resolve the `@types` package as a fallback instead of eagerly
resolving it.
This commit is contained in:
David Sherret 2024-06-08 20:05:28 -04:00 • committed by GitHub
parent 32f5b4808e
commit 31154ff958
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
18 changed files with 96 additions and 101 deletions
Download patch file Download diff file Expand all files Collapse all files

4
cli/npm/managed/mod.rs
View file

@ -23,7 +23,6 @@ use deno_npm::NpmResolutionPackage;
use deno_npm::NpmSystemInfo;
use deno_runtime::deno_fs::FileSystem;
use deno_runtime::deno_node::NodePermissions;
use deno_runtime::deno_node::NodeResolutionMode;
use deno_runtime::deno_node::NpmResolver;
use deno_semver::package::PackageNv;
use deno_semver::package::PackageReq;
@ -531,11 +530,10 @@ impl NpmResolver for ManagedCliNpmResolver {
&self,
name: &str,
referrer: &ModuleSpecifier,
mode: NodeResolutionMode,
) -> Result<PathBuf, AnyError> {
let path = self
.fs_resolver
.resolve_package_folder_from_package(name, referrer, mode)?;
.resolve_package_folder_from_package(name, referrer)?;
let path =
canonicalize_path_maybe_not_exists_with_fs(&path, self.fs.as_ref())?;
log::debug!("Resolved {} from {} to {}", name, referrer, path.display());