language-servers/deno
1
0
Fork 0
mirror of https://github.com/denoland/deno.git synced 2025-10-03 07:34:36 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 4

chore: use ts-expect-error instead of ts-ignore (#6876)

Browse source
This commit is contained in:
Trivikram Kamat 2020-07-26 07:41:10 -07:00 • committed by GitHub
parent 9f3ab4dca7
commit 35a1421fb1
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 17 additions and 25 deletions
Download patch file Download diff file Expand all files Collapse all files

10
std/node/_util/_util_promisify.ts
View file

@ -61,9 +61,9 @@ export function promisify(original: Function): Function {
throw new NodeInvalidArgTypeError("original", "Function", original); throw new NodeInvalidArgTypeError("original", "Function", original);
} }
// @ts-ignore TypeScript (as of 3.7) does not support indexing namespaces by symbol // @ts-expect-error TypeScript (as of 3.7) does not support indexing namespaces by symbol
if (original[kCustomPromisifiedSymbol]) { if (original[kCustomPromisifiedSymbol]) {
// @ts-ignore TypeScript (as of 3.7) does not support indexing namespaces by symbol // @ts-expect-error TypeScript (as of 3.7) does not support indexing namespaces by symbol
const fn = original[kCustomPromisifiedSymbol]; const fn = original[kCustomPromisifiedSymbol];
if (typeof fn !== "function") { if (typeof fn !== "function") {
throw new NodeInvalidArgTypeError( throw new NodeInvalidArgTypeError(
@ -82,12 +82,12 @@ export function promisify(original: Function): Function {
// Names to create an object from in case the callback receives multiple // Names to create an object from in case the callback receives multiple
// arguments, e.g. ['bytesRead', 'buffer'] for fs.read. // arguments, e.g. ['bytesRead', 'buffer'] for fs.read.
// @ts-ignore TypeScript (as of 3.7) does not support indexing namespaces by symbol // @ts-expect-error TypeScript (as of 3.7) does not support indexing namespaces by symbol
const argumentNames = original[kCustomPromisifyArgsSymbol]; const argumentNames = original[kCustomPromisifyArgsSymbol];
function fn(...args: unknown[]): Promise<unknown> { function fn(...args: unknown[]): Promise<unknown> {
return new Promise((resolve, reject) => { return new Promise((resolve, reject) => {
// @ts-ignore: 'this' implicitly has type 'any' because it does not have a type annotation // @ts-expect-error: 'this' implicitly has type 'any' because it does not have a type annotation
original.call(this, ...args, (err: Error, ...values: unknown[]) => { original.call(this, ...args, (err: Error, ...values: unknown[]) => {
if (err) { if (err) {
return reject(err); return reject(err);
@ -95,7 +95,7 @@ export function promisify(original: Function): Function {
if (argumentNames !== undefined && values.length > 1) { if (argumentNames !== undefined && values.length > 1) {
const obj = {}; const obj = {};
for (let i = 0; i < argumentNames.length; i++) { for (let i = 0; i < argumentNames.length; i++) {
// @ts-ignore TypeScript // @ts-expect-error TypeScript
obj[argumentNames[i]] = values[i]; obj[argumentNames[i]] = values[i];
} }
resolve(obj); resolve(obj);

12
std/node/_util/_util_promisify_test.ts
View file

@ -43,7 +43,7 @@ Deno.test("Promisify.custom", async function testPromisifyCustom() {
function fn(): void {} function fn(): void {}
function promisifedFn(): void {} function promisifedFn(): void {}
// @ts-ignore TypeScript (as of 3.7) does not support indexing namespaces by symbol // @ts-expect-error TypeScript (as of 3.7) does not support indexing namespaces by symbol
fn[promisify.custom] = promisifedFn; fn[promisify.custom] = promisifedFn;
const promisifiedFnA = promisify(fn); const promisifiedFnA = promisify(fn);
@ -63,7 +63,7 @@ Deno.test("promiisfy.custom symbol", function testPromisifyCustomSymbol() {
// util.promisify.custom is a shared symbol which can be accessed // util.promisify.custom is a shared symbol which can be accessed
// as `Symbol.for("nodejs.util.promisify.custom")`. // as `Symbol.for("nodejs.util.promisify.custom")`.
const kCustomPromisifiedSymbol = Symbol.for("nodejs.util.promisify.custom"); const kCustomPromisifiedSymbol = Symbol.for("nodejs.util.promisify.custom");
// @ts-ignore TypeScript (as of 3.7) does not support indexing namespaces by symbol // @ts-expect-error TypeScript (as of 3.7) does not support indexing namespaces by symbol
fn[kCustomPromisifiedSymbol] = promisifiedFn; fn[kCustomPromisifiedSymbol] = promisifiedFn;
assertStrictEquals(kCustomPromisifiedSymbol, promisify.custom); assertStrictEquals(kCustomPromisifiedSymbol, promisify.custom);
@ -73,7 +73,7 @@ Deno.test("promiisfy.custom symbol", function testPromisifyCustomSymbol() {
Deno.test("Invalid argument should throw", function testThrowInvalidArgument() { Deno.test("Invalid argument should throw", function testThrowInvalidArgument() {
function fn(): void {} function fn(): void {}
// @ts-ignore TypeScript (as of 3.7) does not support indexing namespaces by symbol // @ts-expect-error TypeScript (as of 3.7) does not support indexing namespaces by symbol
fn[promisify.custom] = 42; fn[promisify.custom] = 42;
try { try {
promisify(fn); promisify(fn);
@ -91,7 +91,7 @@ Deno.test("Custom promisify args", async function testPromisifyCustomArgs() {
callback(null, firstValue, secondValue); callback(null, firstValue, secondValue);
} }
// @ts-ignore TypeScript (as of 3.7) does not support indexing namespaces by symbol // @ts-expect-error TypeScript (as of 3.7) does not support indexing namespaces by symbol
fn[customPromisifyArgs] = ["first", "second"]; fn[customPromisifyArgs] = ["first", "second"];
const obj = await promisify(fn)(); const obj = await promisify(fn)();
@ -159,7 +159,7 @@ Deno.test(
Deno.test("Rejected value", async function testPromisifyWithAsObjectMethod() { Deno.test("Rejected value", async function testPromisifyWithAsObjectMethod() {
const o: { fn?: Function } = {}; const o: { fn?: Function } = {};
const fn = promisify(function (cb: Function): void { const fn = promisify(function (cb: Function): void {
// @ts-ignore TypeScript // @ts-expect-error TypeScript
cb(null, this === o); cb(null, this === o);
}); });
@ -220,7 +220,7 @@ Deno.test("Test error", async function testInvalidArguments() {
Deno.test("Test invalid arguments", function testInvalidArguments() { Deno.test("Test invalid arguments", function testInvalidArguments() {
[undefined, null, true, 0, "str", {}, [], Symbol()].forEach((input) => { [undefined, null, true, 0, "str", {}, [], Symbol()].forEach((input) => {
try { try {
// @ts-ignore TypeScript // @ts-expect-error TypeScript
promisify(input); promisify(input);
} catch (e) { } catch (e) {
assertStrictEquals(e.code, "ERR_INVALID_ARG_TYPE"); assertStrictEquals(e.code, "ERR_INVALID_ARG_TYPE");

20
std/node/buffer_test.ts
View file

@ -5,10 +5,10 @@ Deno.test({
name: "Buffer global scope", name: "Buffer global scope",
fn() { fn() {
// deno-lint-ignore ban-ts-comment // deno-lint-ignore ban-ts-comment
// @ts-ignore // @ts-expect-error
assert(window.Buffer === Buffer); assert(window.Buffer === Buffer);
// deno-lint-ignore ban-ts-comment // deno-lint-ignore ban-ts-comment
// @ts-ignore // @ts-expect-error
assert(globalThis.Buffer === Buffer); assert(globalThis.Buffer === Buffer);
}, },
}); });
@ -36,7 +36,7 @@ Deno.test({
assertThrows( assertThrows(
() => { () => {
// deno-lint-ignore ban-ts-comment // deno-lint-ignore ban-ts-comment
// @ts-ignore // @ts-expect-error
Buffer.alloc(size); Buffer.alloc(size);
}, },
TypeError, TypeError,
@ -55,8 +55,6 @@ Deno.test({
for (const value of invalidValues) { for (const value of invalidValues) {
assertThrows( assertThrows(
() => { () => {
// deno-lint-ignore ban-ts-comment
// @ts-ignore
console.log(value.constructor.name); console.log(value.constructor.name);
Buffer.alloc(1, value); Buffer.alloc(1, value);
}, },
@ -399,7 +397,7 @@ Deno.test({
assertThrows( assertThrows(
() => { () => {
// deno-lint-ignore ban-ts-comment // deno-lint-ignore ban-ts-comment
// @ts-ignore // @ts-expect-error
buffer.toString(encoding); buffer.toString(encoding);
}, },
TypeError, TypeError,
@ -418,15 +416,13 @@ Deno.test({
for (const encoding of defaultToUtf8Encodings) { for (const encoding of defaultToUtf8Encodings) {
// deno-lint-ignore ban-ts-comment // deno-lint-ignore ban-ts-comment
// @ts-ignore // @ts-expect-error
assertEquals(Buffer.from("yes", encoding).toString(), "yes"); assertEquals(Buffer.from("yes", encoding).toString(), "yes");
} }
for (const encoding of invalidEncodings) { for (const encoding of invalidEncodings) {
assertThrows( assertThrows(
() => { () => {
// deno-lint-ignore ban-ts-comment
// @ts-ignore
Buffer.from("yes", encoding); Buffer.from("yes", encoding);
}, },
TypeError, TypeError,
@ -445,8 +441,6 @@ Deno.test({
for (const encoding of notImplemented) { for (const encoding of notImplemented) {
assertThrows( assertThrows(
() => { () => {
// deno-lint-ignore ban-ts-comment
// @ts-ignore
buffer.toString(encoding); buffer.toString(encoding);
}, },
Error, Error,
@ -456,8 +450,6 @@ Deno.test({
assertThrows( assertThrows(
() => { () => {
// deno-lint-ignore ban-ts-comment
// @ts-ignore
Buffer.from("", encoding); Buffer.from("", encoding);
}, },
Error, Error,
@ -586,7 +578,7 @@ Deno.test({
assertThrows( assertThrows(
// deno-lint-ignore ban-ts-comment // deno-lint-ignore ban-ts-comment
// @ts-ignore // @ts-expect-error
() => Buffer.alloc(1).equals("abc"), () => Buffer.alloc(1).equals("abc"),
TypeError, TypeError,
`The "otherBuffer" argument must be an instance of Buffer or Uint8Array. Received type string`, `The "otherBuffer" argument must be an instance of Buffer or Uint8Array. Received type string`,