language-servers/deno
1
0
Fork 0
mirror of https://github.com/denoland/deno.git synced 2025-09-26 20:29:11 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

ci: disable symcache generation on Windows (#30646)

Browse source 
Due to V8 upgrade in https://github.com/denoland/deno/pull/30629, we are
not generating debug symbols on Windows and because of that
symcache generation is not available.
This commit is contained in:
Bartek Iwańczuk 2025-09-09 00:39:54 +02:00 • committed by GitHub
parent c537681065
commit 3e58caa8f4
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
4 changed files with 11 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

4
.github/workflows/ci.generate.ts vendored
View file

@ -916,7 +916,9 @@ const ci = {
"Get-FileHash target/release/deno-${{ matrix.arch }}-pc-windows-msvc.zip -Algorithm SHA256 | Format-List > target/release/deno-${{ matrix.arch }}-pc-windows-msvc.zip.sha256sum", "Get-FileHash target/release/deno-${{ matrix.arch }}-pc-windows-msvc.zip -Algorithm SHA256 | Format-List > target/release/deno-${{ matrix.arch }}-pc-windows-msvc.zip.sha256sum",
"Compress-Archive -CompressionLevel Optimal -Force -Path target/release/denort.exe -DestinationPath target/release/denort-${{ matrix.arch }}-pc-windows-msvc.zip", "Compress-Archive -CompressionLevel Optimal -Force -Path target/release/denort.exe -DestinationPath target/release/denort-${{ matrix.arch }}-pc-windows-msvc.zip",
"Get-FileHash target/release/denort-${{ matrix.arch }}-pc-windows-msvc.zip -Algorithm SHA256 | Format-List > target/release/denort-${{ matrix.arch }}-pc-windows-msvc.zip.sha256sum", "Get-FileHash target/release/denort-${{ matrix.arch }}-pc-windows-msvc.zip -Algorithm SHA256 | Format-List > target/release/denort-${{ matrix.arch }}-pc-windows-msvc.zip.sha256sum",
"target/release/deno.exe -A tools/release/create_symcache.ts target/release/deno-${{ matrix.arch }}-pc-windows-msvc.symcache", // TODO(bartlomieju): fix the regression from V8 upgrade
// https://github.com/denoland/deno/pull/30629
// "target/release/deno.exe -A tools/release/create_symcache.ts target/release/deno-${{ matrix.arch }}-pc-windows-msvc.symcache",
].join("\n"), ].join("\n"),
}, },
{ {

1
.github/workflows/ci.yml vendored
View file

@ -560,7 +560,6 @@ jobs:
Get-FileHash target/release/deno-${{ matrix.arch }}-pc-windows-msvc.zip -Algorithm SHA256 | Format-List > target/release/deno-${{ matrix.arch }}-pc-windows-msvc.zip.sha256sum Get-FileHash target/release/deno-${{ matrix.arch }}-pc-windows-msvc.zip -Algorithm SHA256 | Format-List > target/release/deno-${{ matrix.arch }}-pc-windows-msvc.zip.sha256sum
Compress-Archive -CompressionLevel Optimal -Force -Path target/release/denort.exe -DestinationPath target/release/denort-${{ matrix.arch }}-pc-windows-msvc.zip Compress-Archive -CompressionLevel Optimal -Force -Path target/release/denort.exe -DestinationPath target/release/denort-${{ matrix.arch }}-pc-windows-msvc.zip
Get-FileHash target/release/denort-${{ matrix.arch }}-pc-windows-msvc.zip -Algorithm SHA256 | Format-List > target/release/denort-${{ matrix.arch }}-pc-windows-msvc.zip.sha256sum Get-FileHash target/release/denort-${{ matrix.arch }}-pc-windows-msvc.zip -Algorithm SHA256 | Format-List > target/release/denort-${{ matrix.arch }}-pc-windows-msvc.zip.sha256sum
target/release/deno.exe -A tools/release/create_symcache.ts target/release/deno-${{ matrix.arch }}-pc-windows-msvc.symcache
- name: Upload canary to dl.deno.land - name: Upload canary to dl.deno.land
if: |- if: |-
!(matrix.skip) && (matrix.job == 'test' && !(matrix.skip) && (matrix.job == 'test' &&

4
tools/deno.lock.json
View file

@ -32,6 +32,7 @@
"jsr:@std/semver@1.0.3": "1.0.3", "jsr:@std/semver@1.0.3": "1.0.3",
"jsr:@std/streams@0.221": "0.221.0", "jsr:@std/streams@0.221": "0.221.0",
"jsr:@std/streams@0.221.0": "0.221.0", "jsr:@std/streams@0.221.0": "0.221.0",
"jsr:@std/yaml@0.221": "0.221.0",
"jsr:@ts-morph/common@0.24": "0.24.0", "jsr:@ts-morph/common@0.24": "0.24.0",
"jsr:@ts-morph/ts-morph@23.0.0": "23.0.0", "jsr:@ts-morph/ts-morph@23.0.0": "23.0.0",
"npm:@types/decompress@4.2.7": "4.2.7", "npm:@types/decompress@4.2.7": "4.2.7",
@ -157,6 +158,9 @@
"jsr:@std/io@0.221" "jsr:@std/io@0.221"
] ]
}, },
"@std/yaml@0.221.0": {
"integrity": "bac8913ee4f6fc600d4b92cc020f755070e22687ad242341f31d123ff690ae98"
},
"@ts-morph/common@0.24.0": { "@ts-morph/common@0.24.0": {
"integrity": "12b625b8e562446ba658cdbe9ad77774b4bd96b992ae8bd34c60dbf24d06c1f3", "integrity": "12b625b8e562446ba658cdbe9ad77774b4bd96b992ae8bd34c60dbf24d06c1f3",
"dependencies": [ "dependencies": [

5
tools/release/create_symcache.ts
View file

@ -10,7 +10,10 @@ import path from "node:path";
let debugFile = Deno.execPath(); let debugFile = Deno.execPath();
if (Deno.build.os === "windows") { if (Deno.build.os === "windows") {
debugFile = debugFile.replace(/\.exe$/, ".pdb"); // TODO(bartlomieju): fix the regression from V8 upgrade
// https://github.com/denoland/deno/pull/30629
// debugFile = debugFile.replace(/\.exe$/, ".pdb");
Deno.exit(0);
} else if (Deno.build.os === "darwin") { } else if (Deno.build.os === "darwin") {
const resolvedPath = Deno.realPathSync(`${debugFile}.dSYM`); const resolvedPath = Deno.realPathSync(`${debugFile}.dSYM`);
const { name } = path.parse(resolvedPath); const { name } = path.parse(resolvedPath);