refactor(cli/tests): remove unnecessary void return types (#11577)

This commit is contained in:
Leo K 2021-08-05 13:08:58 +02:00 committed by GitHub
parent 299c7cfe54
commit 3f0cf9619f
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
121 changed files with 1095 additions and 1177 deletions

View file

@ -8,7 +8,7 @@ import {
unitTest,
} from "./test_util.ts";
function assertDirectory(path: string, mode?: number): void {
function assertDirectory(path: string, mode?: number) {
const info = Deno.lstatSync(path);
assert(info.isDirectory);
if (Deno.build.os !== "windows" && mode !== undefined) {
@ -18,7 +18,7 @@ function assertDirectory(path: string, mode?: number): void {
unitTest(
{ perms: { read: true, write: true } },
function mkdirSyncSuccess(): void {
function mkdirSyncSuccess() {
const path = Deno.makeTempDirSync() + "/dir";
Deno.mkdirSync(path);
assertDirectory(path);
@ -27,14 +27,14 @@ unitTest(
unitTest(
{ perms: { read: true, write: true } },
function mkdirSyncMode(): void {
function mkdirSyncMode() {
const path = Deno.makeTempDirSync() + "/dir";
Deno.mkdirSync(path, { mode: 0o737 });
assertDirectory(path, 0o737);
},
);
unitTest({ perms: { write: false } }, function mkdirSyncPerm(): void {
unitTest({ perms: { write: false } }, function mkdirSyncPerm() {
assertThrows(() => {
Deno.mkdirSync("/baddir");
}, Deno.errors.PermissionDenied);
@ -42,7 +42,7 @@ unitTest({ perms: { write: false } }, function mkdirSyncPerm(): void {
unitTest(
{ perms: { read: true, write: true } },
async function mkdirSuccess(): Promise<void> {
async function mkdirSuccess() {
const path = Deno.makeTempDirSync() + "/dir";
await Deno.mkdir(path);
assertDirectory(path);
@ -51,22 +51,20 @@ unitTest(
unitTest(
{ perms: { read: true, write: true } },
async function mkdirMode(): Promise<void> {
async function mkdirMode() {
const path = Deno.makeTempDirSync() + "/dir";
await Deno.mkdir(path, { mode: 0o737 });
assertDirectory(path, 0o737);
},
);
unitTest({ perms: { write: true } }, function mkdirErrSyncIfExists(): void {
unitTest({ perms: { write: true } }, function mkdirErrSyncIfExists() {
assertThrows(() => {
Deno.mkdirSync(".");
}, Deno.errors.AlreadyExists);
});
unitTest({ perms: { write: true } }, async function mkdirErrIfExists(): Promise<
void
> {
unitTest({ perms: { write: true } }, async function mkdirErrIfExists() {
await assertThrowsAsync(async () => {
await Deno.mkdir(".");
}, Deno.errors.AlreadyExists);
@ -74,7 +72,7 @@ unitTest({ perms: { write: true } }, async function mkdirErrIfExists(): Promise<
unitTest(
{ perms: { read: true, write: true } },
function mkdirSyncRecursive(): void {
function mkdirSyncRecursive() {
const path = Deno.makeTempDirSync() + "/nested/directory";
Deno.mkdirSync(path, { recursive: true });
assertDirectory(path);
@ -83,7 +81,7 @@ unitTest(
unitTest(
{ perms: { read: true, write: true } },
async function mkdirRecursive(): Promise<void> {
async function mkdirRecursive() {
const path = Deno.makeTempDirSync() + "/nested/directory";
await Deno.mkdir(path, { recursive: true });
assertDirectory(path);
@ -92,7 +90,7 @@ unitTest(
unitTest(
{ perms: { read: true, write: true } },
function mkdirSyncRecursiveMode(): void {
function mkdirSyncRecursiveMode() {
const nested = Deno.makeTempDirSync() + "/nested";
const path = nested + "/dir";
Deno.mkdirSync(path, { mode: 0o737, recursive: true });
@ -103,7 +101,7 @@ unitTest(
unitTest(
{ perms: { read: true, write: true } },
async function mkdirRecursiveMode(): Promise<void> {
async function mkdirRecursiveMode() {
const nested = Deno.makeTempDirSync() + "/nested";
const path = nested + "/dir";
await Deno.mkdir(path, { mode: 0o737, recursive: true });
@ -114,7 +112,7 @@ unitTest(
unitTest(
{ perms: { read: true, write: true } },
function mkdirSyncRecursiveIfExists(): void {
function mkdirSyncRecursiveIfExists() {
const path = Deno.makeTempDirSync() + "/dir";
Deno.mkdirSync(path, { mode: 0o737 });
Deno.mkdirSync(path, { recursive: true });
@ -132,7 +130,7 @@ unitTest(
unitTest(
{ perms: { read: true, write: true } },
async function mkdirRecursiveIfExists(): Promise<void> {
async function mkdirRecursiveIfExists() {
const path = Deno.makeTempDirSync() + "/dir";
await Deno.mkdir(path, { mode: 0o737 });
await Deno.mkdir(path, { recursive: true });
@ -150,7 +148,7 @@ unitTest(
unitTest(
{ perms: { read: true, write: true } },
function mkdirSyncErrors(): void {
function mkdirSyncErrors() {
const testDir = Deno.makeTempDirSync();
const emptydir = testDir + "/empty";
const fulldir = testDir + "/dir";
@ -159,16 +157,16 @@ unitTest(
Deno.mkdirSync(fulldir);
Deno.createSync(file).close();
assertThrows((): void => {
assertThrows(() => {
Deno.mkdirSync(emptydir, { recursive: false });
}, Deno.errors.AlreadyExists);
assertThrows((): void => {
assertThrows(() => {
Deno.mkdirSync(fulldir, { recursive: false });
}, Deno.errors.AlreadyExists);
assertThrows((): void => {
assertThrows(() => {
Deno.mkdirSync(file, { recursive: false });
}, Deno.errors.AlreadyExists);
assertThrows((): void => {
assertThrows(() => {
Deno.mkdirSync(file, { recursive: true });
}, Deno.errors.AlreadyExists);
@ -180,19 +178,19 @@ unitTest(
Deno.symlinkSync(emptydir, dirLink);
Deno.symlinkSync(testDir + "/nonexistent", danglingLink);
assertThrows((): void => {
assertThrows(() => {
Deno.mkdirSync(dirLink, { recursive: false });
}, Deno.errors.AlreadyExists);
assertThrows((): void => {
assertThrows(() => {
Deno.mkdirSync(fileLink, { recursive: false });
}, Deno.errors.AlreadyExists);
assertThrows((): void => {
assertThrows(() => {
Deno.mkdirSync(fileLink, { recursive: true });
}, Deno.errors.AlreadyExists);
assertThrows((): void => {
assertThrows(() => {
Deno.mkdirSync(danglingLink, { recursive: false });
}, Deno.errors.AlreadyExists);
assertThrows((): void => {
assertThrows(() => {
Deno.mkdirSync(danglingLink, { recursive: true });
}, Deno.errors.AlreadyExists);
}
@ -201,7 +199,7 @@ unitTest(
unitTest(
{ perms: { read: true, write: true } },
function mkdirSyncRelativeUrlPath(): void {
function mkdirSyncRelativeUrlPath() {
const testDir = Deno.makeTempDirSync();
const nestedDir = testDir + "/nested";
// Add trailing slash so base path is treated as a directory. pathToAbsoluteFileUrl removes trailing slashes.
@ -216,7 +214,7 @@ unitTest(
unitTest(
{ perms: { read: true, write: true } },
async function mkdirRelativeUrlPath(): Promise<void> {
async function mkdirRelativeUrlPath() {
const testDir = Deno.makeTempDirSync();
const nestedDir = testDir + "/nested";
// Add trailing slash so base path is treated as a directory. pathToAbsoluteFileUrl removes trailing slashes.