language-servers/deno
1
0
Fork 0
mirror of https://github.com/denoland/deno.git synced 2025-08-04 19:08:15 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

fix(ext/node): handle non-ws upgrade headers (#27931)

Browse source
This commit is contained in:
Divy Srivastava 2025-02-04 17:35:48 +05:30 • committed by GitHub
parent 4405f47a4f
commit 441b1d307f
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 34 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

7
ext/node/polyfills/http.ts
View file

@ -548,8 +548,11 @@ class ClientRequest extends OutgoingMessage {
incoming.statusMessage = res.statusText;
incoming.upgrade = null;
for (const [key, _value] of res.headers) {
if (key.toLowerCase() === "upgrade") {
for (const [key, value] of res.headers) {
if (
key.toLowerCase() === "upgrade" &&
value.toLowerCase() === "websocket"
) {
incoming.upgrade = true;
break;
}

29
tests/unit_node/http_test.ts
View file

@ -372,6 +372,35 @@ Deno.test("[node/http] request default protocol", async () => {
assertEquals(clientRes!.complete, true);
});
Deno.test("[node/http] request non-ws upgrade header", async () => {
const { promise, resolve } = Promise.withResolvers<void>();
const server = http.createServer((_req, res) => {
res.writeHead(200, { "upgrade": "h2,h2c" });
res.end("ok");
});
server.listen(() => {
const req = http.request(
{
host: "localhost",
// deno-lint-ignore no-explicit-any
port: (server.address() as any).port,
},
(res) => {
res.on("data", () => {});
res.on("end", () => {
server.close();
});
assertEquals(res.statusCode, 200);
},
);
req.end();
});
server.on("close", () => {
resolve();
});
await promise;
});
Deno.test("[node/http] request with headers", async () => {
const { promise, resolve } = Promise.withResolvers<void>();
const server = http.createServer((req, res) => {