perf(core): preserve ops between snapshots (#18080)

This commit changes the build process in a way that preserves already registered ops in the snapshot. This allows us to skip creating hundreds of "v8::String" on each startup, but sadly there is still some op registration going on startup (however we're registering 49 ops instead of >200 ops). This situation could be further improved, by moving some of the ops from "runtime/" to a separate extension crates. --------- Co-authored-by: Divy Srivastava <dj.srivastava23@gmail.com>
2025-08-04 19:08:15 +00:00 · 2023-03-18 07:51:21 -04:00 · 2023-03-18 07:51:21 -04:00 · 4b6305f4f2
commit 4b6305f4f2
parent 9bfa8dc90c
54 changed files with 278 additions and 125 deletions
--- a/ops/lib.rs
+++ b/ops/lib.rs
@ -145,6 +145,7 @@ impl Op {
              is_async: #is_async,
              is_unstable: #is_unstable,
              is_v8: #is_v8,
+              force_registration: false,
            }
          }

@ -201,6 +202,7 @@ impl Op {
            is_async: #is_async,
            is_unstable: #is_unstable,
            is_v8: #is_v8,
+            force_registration: false,
          }
        }

--- a/ops/optimizer_tests/async_nop.out
+++ b/ops/optimizer_tests/async_nop.out
@ -26,6 +26,7 @@ impl op_void_async {
            is_async: true,
            is_unstable: false,
            is_v8: false,
+            force_registration: false,
        }
    }
    #[inline]
--- a/ops/optimizer_tests/async_result.out
+++ b/ops/optimizer_tests/async_result.out
@ -26,6 +26,7 @@ impl op_async_result {
            is_async: true,
            is_unstable: false,
            is_v8: false,
+            force_registration: false,
        }
    }
    #[inline]
--- a/ops/optimizer_tests/callback_options.out
+++ b/ops/optimizer_tests/callback_options.out
@ -26,6 +26,7 @@ impl op_fallback {
            is_async: false,
            is_unstable: false,
            is_v8: false,
+            force_registration: false,
        }
    }
    #[inline]
--- a/ops/optimizer_tests/cow_str.out
+++ b/ops/optimizer_tests/cow_str.out
@ -26,6 +26,7 @@ impl op_cow_str {
            is_async: false,
            is_unstable: false,
            is_v8: false,
+            force_registration: false,
        }
    }
    #[inline]
--- a/ops/optimizer_tests/f64_slice.out
+++ b/ops/optimizer_tests/f64_slice.out
@ -26,6 +26,7 @@ impl op_f64_buf {
            is_async: false,
            is_unstable: false,
            is_v8: false,
+            force_registration: false,
        }
    }
    #[inline]
--- a/ops/optimizer_tests/incompatible_1.out
+++ b/ops/optimizer_tests/incompatible_1.out
@ -22,6 +22,7 @@ impl op_sync_serialize_object_with_numbers_as_keys {
            is_async: false,
            is_unstable: false,
            is_v8: false,
+            force_registration: false,
        }
    }
    #[inline]
--- a/ops/optimizer_tests/issue16934.out
+++ b/ops/optimizer_tests/issue16934.out
@ -22,6 +22,7 @@ impl send_stdin {
            is_async: true,
            is_unstable: false,
            is_v8: false,
+            force_registration: false,
        }
    }
    #[inline]
--- a/ops/optimizer_tests/issue16934_fast.out
+++ b/ops/optimizer_tests/issue16934_fast.out
@ -22,6 +22,7 @@ impl send_stdin {
            is_async: true,
            is_unstable: false,
            is_v8: false,
+            force_registration: false,
        }
    }
    #[inline]
--- a/ops/optimizer_tests/op_blob_revoke_object_url.out
+++ b/ops/optimizer_tests/op_blob_revoke_object_url.out
@ -22,6 +22,7 @@ impl op_blob_revoke_object_url {
            is_async: false,
            is_unstable: false,
            is_v8: false,
+            force_registration: false,
        }
    }
    #[inline]
--- a/ops/optimizer_tests/op_ffi_ptr_value.out
+++ b/ops/optimizer_tests/op_ffi_ptr_value.out
@ -26,6 +26,7 @@ impl op_ffi_ptr_value {
            is_async: false,
            is_unstable: false,
            is_v8: false,
+            force_registration: false,
        }
    }
    #[inline]
--- a/ops/optimizer_tests/op_print.out
+++ b/ops/optimizer_tests/op_print.out
@ -22,6 +22,7 @@ impl op_print {
            is_async: false,
            is_unstable: false,
            is_v8: false,
+            force_registration: false,
        }
    }
    #[inline]
--- a/ops/optimizer_tests/op_state.out
+++ b/ops/optimizer_tests/op_state.out
@ -26,6 +26,7 @@ impl op_set_exit_code {
            is_async: false,
            is_unstable: false,
            is_v8: false,
+            force_registration: false,
        }
    }
    #[inline]
--- a/ops/optimizer_tests/op_state_basic1.out
+++ b/ops/optimizer_tests/op_state_basic1.out
@ -26,6 +26,7 @@ impl foo {
            is_async: false,
            is_unstable: false,
            is_v8: false,
+            force_registration: false,
        }
    }
    #[inline]
--- a/ops/optimizer_tests/op_state_generics.out
+++ b/ops/optimizer_tests/op_state_generics.out
@ -32,6 +32,7 @@ impl op_foo {
            is_async: false,
            is_unstable: false,
            is_v8: false,
+            force_registration: false,
        }
    }
    #[inline]
--- a/ops/optimizer_tests/op_state_result.out
+++ b/ops/optimizer_tests/op_state_result.out
@ -26,6 +26,7 @@ impl foo {
            is_async: false,
            is_unstable: false,
            is_v8: false,
+            force_registration: false,
        }
    }
    #[inline]
--- a/ops/optimizer_tests/op_state_warning.out
+++ b/ops/optimizer_tests/op_state_warning.out
@ -26,6 +26,7 @@ impl op_listen {
            is_async: false,
            is_unstable: false,
            is_v8: false,
+            force_registration: false,
        }
    }
    #[inline]
--- a/ops/optimizer_tests/op_state_with_transforms.out
+++ b/ops/optimizer_tests/op_state_with_transforms.out
@ -32,6 +32,7 @@ impl op_now {
            is_async: false,
            is_unstable: false,
            is_v8: false,
+            force_registration: false,
        }
    }
    #[inline]
--- a/ops/optimizer_tests/opstate_with_arity.out
+++ b/ops/optimizer_tests/opstate_with_arity.out
@ -26,6 +26,7 @@ impl op_add_4 {
            is_async: false,
            is_unstable: false,
            is_v8: false,
+            force_registration: false,
        }
    }
    #[inline]
--- a/ops/optimizer_tests/option_arg.out
+++ b/ops/optimizer_tests/option_arg.out
@ -22,6 +22,7 @@ impl op_try_close {
            is_async: false,
            is_unstable: false,
            is_v8: false,
+            force_registration: false,
        }
    }
    #[inline]
--- a/ops/optimizer_tests/owned_string.out
+++ b/ops/optimizer_tests/owned_string.out
@ -26,6 +26,7 @@ impl op_string_length {
            is_async: false,
            is_unstable: false,
            is_v8: false,
+            force_registration: false,
        }
    }
    #[inline]
--- a/ops/optimizer_tests/param_mut_binding_warning.out
+++ b/ops/optimizer_tests/param_mut_binding_warning.out
@ -22,6 +22,7 @@ impl op_read_sync {
            is_async: false,
            is_unstable: false,
            is_v8: false,
+            force_registration: false,
        }
    }
    #[inline]
--- a/ops/optimizer_tests/raw_ptr.out
+++ b/ops/optimizer_tests/raw_ptr.out
@ -32,6 +32,7 @@ impl op_ffi_ptr_of {
            is_async: false,
            is_unstable: false,
            is_v8: false,
+            force_registration: false,
        }
    }
    #[inline]
--- a/ops/optimizer_tests/serde_v8_value.out
+++ b/ops/optimizer_tests/serde_v8_value.out
@ -26,6 +26,7 @@ impl op_is_proxy {
            is_async: false,
            is_unstable: false,
            is_v8: false,
+            force_registration: false,
        }
    }
    #[inline]
--- a/ops/optimizer_tests/strings.out
+++ b/ops/optimizer_tests/strings.out
@ -26,6 +26,7 @@ impl op_string_length {
            is_async: false,
            is_unstable: false,
            is_v8: false,
+            force_registration: false,
        }
    }
    #[inline]
--- a/ops/optimizer_tests/strings_result.out
+++ b/ops/optimizer_tests/strings_result.out
@ -22,6 +22,7 @@ impl op_string_length {
            is_async: false,
            is_unstable: false,
            is_v8: false,
+            force_registration: false,
        }
    }
    #[inline]
--- a/ops/optimizer_tests/u64_result.out
+++ b/ops/optimizer_tests/u64_result.out
@ -22,6 +22,7 @@ impl op_bench_now {
            is_async: false,
            is_unstable: false,
            is_v8: false,
+            force_registration: false,
        }
    }
    #[inline]
--- a/ops/optimizer_tests/uint8array.out
+++ b/ops/optimizer_tests/uint8array.out
@ -26,6 +26,7 @@ impl op_import_spki_x25519 {
            is_async: false,
            is_unstable: false,
            is_v8: false,
+            force_registration: false,
        }
    }
    #[inline]
--- a/ops/optimizer_tests/unit_result.out
+++ b/ops/optimizer_tests/unit_result.out
@ -26,6 +26,7 @@ impl op_unit_result {
            is_async: false,
            is_unstable: false,
            is_v8: false,
+            force_registration: false,
        }
    }
    #[inline]
--- a/ops/optimizer_tests/unit_result2.out
+++ b/ops/optimizer_tests/unit_result2.out
@ -26,6 +26,7 @@ impl op_set_nodelay {
            is_async: false,
            is_unstable: false,
            is_v8: false,
+            force_registration: false,
        }
    }
    #[inline]
--- a/ops/optimizer_tests/unit_ret.out
+++ b/ops/optimizer_tests/unit_ret.out
@ -26,6 +26,7 @@ impl op_unit {
            is_async: false,
            is_unstable: false,
            is_v8: false,
+            force_registration: false,
        }
    }
    #[inline]
--- a/ops/optimizer_tests/wasm_op.out
+++ b/ops/optimizer_tests/wasm_op.out
@ -26,6 +26,7 @@ impl op_wasm {
            is_async: false,
            is_unstable: false,
            is_v8: false,
+            force_registration: false,
        }
    }
    #[inline]