language-servers/deno
1
0
Fork 0
mirror of https://github.com/denoland/deno.git synced 2025-09-30 14:11:14 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 4

check URLSearchParams.constructor's params (#2488)

Browse source
This commit is contained in:
迷渡 2019-06-10 19:20:59 +08:00 • committed by Ryan Dahl
parent a115340288
commit 5871d22d9b
2 changed files with 18 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

10
js/url_search_params.ts
View file

@ -280,11 +280,11 @@ export class URLSearchParams {
// Overload: sequence<sequence<USVString>>
for (const tuple of init) {
// If pair does not contain exactly two items, then throw a TypeError.
requiredArguments(
"URLSearchParams.constructor tuple array argument",
tuple.length,
2
);
if (tuple.length !== 2) {
throw new TypeError(
"URLSearchParams.constructor tuple array argument must only contain pair elements"
);
}
this.append(tuple[0], tuple[1]);
}
}

13
js/url_search_params_test.ts
View file

@ -147,6 +147,19 @@ test(function urlSearchParamsShouldThrowTypeError(): void {
}
assertEquals(hasThrown, 2);
try {
new URLSearchParams([["1", "2", "3"]]);
hasThrown = 1;
} catch (err) {
if (err instanceof TypeError) {
hasThrown = 2;
} else {
hasThrown = 3;
}
}
assertEquals(hasThrown, 2);
});
test(function urlSearchParamsAppendArgumentsCheck(): void {