language-servers/deno
1
0
Fork 0
mirror of https://github.com/denoland/deno.git synced 2025-09-26 20:29:11 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

fix(ext/node): use primordials in ext/node/polyfills/internal/cli_table.ts (#29257)

Browse source 
Towards #24236. Replaces JS intrinsics with their equivalent primordial
versions.
This commit is contained in:
James Bronder 2025-05-11 17:47:28 -07:00 • committed by GitHub
parent 2a01ac4482
commit 5ab029db22
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 24 additions and 14 deletions
Download patch file Download diff file Expand all files Collapse all files

38
ext/node/polyfills/internal/cli_table.ts
View file

@ -1,10 +1,17 @@
// Copyright 2018-2025 the Deno authors. MIT license. // Copyright 2018-2025 the Deno authors. MIT license.
// Copyright Joyent and Node contributors. All rights reserved. MIT license. // Copyright Joyent and Node contributors. All rights reserved. MIT license.
// TODO(petamoriken): enable prefer-primordials for node polyfills
// deno-lint-ignore-file prefer-primordials
import { getStringWidth } from "ext:deno_node/internal/util/inspect.mjs"; import { getStringWidth } from "ext:deno_node/internal/util/inspect.mjs";
import { primordials } from "ext:core/mod.js";
const {
ArrayPrototypeJoin,
ArrayPrototypeMap,
SafeArrayIterator,
StringPrototypeRepeat,
MathCeil,
MathMax,
ObjectHasOwn,
} = primordials;
const tableChars = { const tableChars = {
middleMiddle: "\u2500", middleMiddle: "\u2500",
@ -30,7 +37,7 @@ const renderRow = (row: string[], columnWidths: number[]) => {
const needed = columnWidths[i] - len; const needed = columnWidths[i] - len;
// round(needed) + ceil(needed) will always add up to the amount // round(needed) + ceil(needed) will always add up to the amount
// of spaces we need while also left justifying the output. // of spaces we need while also left justifying the output.
out += cell + " ".repeat(Math.ceil(needed)); out += cell + StringPrototypeRepeat(" ", MathCeil(needed));
if (i !== row.length - 1) { if (i !== row.length - 1) {
out += tableChars.middle; out += tableChars.middle;
} }
@ -41,8 +48,10 @@ const renderRow = (row: string[], columnWidths: number[]) => {
const table = (head: string[], columns: string[][]) => { const table = (head: string[], columns: string[][]) => {
const rows: string[][] = []; const rows: string[][] = [];
const columnWidths = head.map((h) => getStringWidth(h)); const columnWidths = ArrayPrototypeMap(head, (h) => getStringWidth(h));
const longestColumn = Math.max(...columns.map((a) => a.length)); const longestColumn = MathMax(
...new SafeArrayIterator(ArrayPrototypeMap(columns, (a) => a.length)),
);
for (let i = 0; i < head.length; i++) { for (let i = 0; i < head.length; i++) {
const column = columns[i]; const column = columns[i];
@ -50,31 +59,32 @@ const table = (head: string[], columns: string[][]) => {
if (rows[j] === undefined) { if (rows[j] === undefined) {
rows[j] = []; rows[j] = [];
} }
const value = rows[j][i] = Object.hasOwn(column, j) ? column[j] : ""; const value = rows[j][i] = ObjectHasOwn(column, j) ? column[j] : "";
const width = columnWidths[i] || 0; const width = columnWidths[i] || 0;
const counted = getStringWidth(value); const counted = getStringWidth(value);
columnWidths[i] = Math.max(width, counted); columnWidths[i] = MathMax(width, counted);
} }
} }
const divider = columnWidths.map((i) => const divider = ArrayPrototypeMap(
tableChars.middleMiddle.repeat(i + 2) columnWidths,
(i) => StringPrototypeRepeat(tableChars.middleMiddle, i + 2),
); );
let result = tableChars.topLeft + let result = tableChars.topLeft +
divider.join(tableChars.topMiddle) + ArrayPrototypeJoin(divider, tableChars.topMiddle) +
tableChars.topRight + "\n" + tableChars.topRight + "\n" +
renderRow(head, columnWidths) + "\n" + renderRow(head, columnWidths) + "\n" +
tableChars.leftMiddle + tableChars.leftMiddle +
divider.join(tableChars.rowMiddle) + ArrayPrototypeJoin(divider, tableChars.rowMiddle) +
tableChars.rightMiddle + "\n"; tableChars.rightMiddle + "\n";
for (const row of rows) { for (const row of new SafeArrayIterator(rows)) {
result += `${renderRow(row, columnWidths)}\n`; result += `${renderRow(row, columnWidths)}\n`;
} }
result += tableChars.bottomLeft + result += tableChars.bottomLeft +
divider.join(tableChars.bottomMiddle) + ArrayPrototypeJoin(divider, tableChars.bottomMiddle) +
tableChars.bottomRight; tableChars.bottomRight;
return result; return result;