language-servers/deno
1
0
Fork 0
mirror of https://github.com/denoland/deno.git synced 2025-09-26 12:19:12 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

Use globalThis to reference global scope (#3719)

Browse source 
Co-authored-by: Bartek Iwańczuk <biwanczuk@gmail.com>
This commit is contained in:
Kitson Kelly 2020-01-21 01:30:30 +11:00 • committed by Ry Dahl
parent 23e67eb515
commit 60b53fd6b6
19 changed files with 219 additions and 264 deletions
Download patch file Download diff file Expand all files Collapse all files

17
cli/js/repl.ts
View file

@ -1,7 +1,6 @@
// Copyright 2018-2020 the Deno authors. All rights reserved. MIT license.
import { close } from "./files.ts";
import { exit } from "./os.ts";
import { window } from "./window.ts";
import { core } from "./core.ts";
import { formatError } from "./format_error.ts";
import { stringifyArgs } from "./console.ts";
@ -104,8 +103,8 @@ function evaluate(code: string): boolean {
// @internal
export async function replLoop(): Promise<void> {
const { console } = window;
Object.defineProperties(window, replCommands);
const { console } = globalThis;
Object.defineProperties(globalThis, replCommands);
const historyFile = "deno_history.txt";
const rid = startRepl(historyFile);
@ -118,12 +117,12 @@ export async function replLoop(): Promise<void> {
exit(exitCode);
};
// Configure window._ to give the last evaluation result.
Object.defineProperty(window, "_", {
// Configure globalThis._ to give the last evaluation result.
Object.defineProperty(globalThis, "_", {
configurable: true,
get: (): Value => lastEvalResult,
set: (value: Value): Value => {
Object.defineProperty(window, "_", {
Object.defineProperty(globalThis, "_", {
value: value,
writable: true,
enumerable: true,
@ -133,12 +132,12 @@ export async function replLoop(): Promise<void> {
}
});
// Configure window._error to give the last thrown error.
Object.defineProperty(window, "_error", {
// Configure globalThis._error to give the last thrown error.
Object.defineProperty(globalThis, "_error", {
configurable: true,
get: (): Value => lastThrownError,
set: (value: Value): Value => {
Object.defineProperty(window, "_error", {
Object.defineProperty(globalThis, "_error", {
value: value,
writable: true,
enumerable: true,