fix(audit): remove unwrap in favor of log, don't print empty reports (#31479)

Changes to print reports from socket.dev, only if something is found.

cli/tools/pm/audit.rs

@@ -663,10 +663,14 @@ mod socket_dev {
           None
         }
       })
-      .map(|json_response| {
-        let response: FirewallResponse =
-          serde_json::from_str(&json_response).unwrap();
-        response
+      .filter_map(|json_response| {
+        match serde_json::from_str::<FirewallResponse>(&json_response) {
+          Ok(response) => Some(response),
+          Err(err) => {
+            log::error!("Failed deserializing socket.dev response {:?}", err);
+            None
+          }
+        }
       })
       .collect::<Vec<_>>();
 
@@ -676,6 +680,15 @@ mod socket_dev {
   fn print_firewall_report(responses: &[FirewallResponse]) {
     let stdout = &mut std::io::stdout();
 
+    let responses_with_alerts = responses
+      .iter()
+      .filter(|r| !r.alerts.is_empty())
+      .collect::<Vec<_>>();
+
+    if responses_with_alerts.is_empty() {
+      return;
+    }
+
     _ = writeln!(stdout);
     _ = writeln!(stdout, "{}", colors::bold("Socket.dev firewall report"));
     _ = writeln!(stdout);
@@ -687,11 +700,7 @@ mod socket_dev {
     let mut total_low = 0;
     let mut packages_with_issues = 0;
 
-    for response in responses {
-      if response.alerts.is_empty() && response.score.is_none() {
-        continue;
-      }
-
+    for response in responses_with_alerts {
       packages_with_issues += 1;
 
       _ = writeln!(stdout, "╭ pkg:npm/{}@{}", response.name, response.version);