language-servers/deno
1
0
Fork 0
mirror of https://github.com/denoland/deno.git synced 2025-08-04 19:08:15 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

fix(ext/fetch): better error if no content-type

Browse source 
The streaming WASM support code inspects the Response object's
Content-Type header but if that was missing, it failed with a fairly
inscrutable "String.prototype.toLowerCase called on null or undefined"
exception. Now it raises a more legible "Invalid WebAssembly content
type" exception.
This commit is contained in:
Ben Noordhuis 2021-08-16 12:53:30 +02:00 • committed by Luca Casonato
parent 6ddabb7427
commit 6ced7b0383
2 changed files with 16 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

5
ext/fetch/26_fetch.js
View file

@ -503,9 +503,10 @@
// The spec is ambiguous here, see
// https://github.com/WebAssembly/spec/issues/1138. The WPT tests
// expect the raw value of the Content-Type attribute lowercased.
const contentType = res.headers.get("Content-Type");
if (
StringPrototypeToLowerCase(res.headers.get("Content-Type")) !==
"application/wasm"
typeof contentType !== "string" ||
StringPrototypeToLowerCase(contentType) !== "application/wasm"
) {
throw new TypeError("Invalid WebAssembly content type.");
}