language-servers/deno
1
0
Fork 0
mirror of https://github.com/denoland/deno.git synced 2025-09-28 05:04:48 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

feat: Deno.test() sanitizes ops and resources (#4399)

Browse source 
This PR brings assertOps and assertResources sanitizers to Deno.test() API.

assertOps checks that test doesn't leak async ops, ie. there are no unresolved
promises originating from Deno APIs. Enabled by default, can be disabled using 
Deno.TestDefinition.disableOpSanitizer.

assertResources checks that test doesn't leak resources, ie. all resources used
in test are closed. For example; if a file is opened during a test case it must be
explicitly closed before test case finishes. It's most useful for asynchronous
generators. Enabled by default, can be disabled using 
Deno.TestDefinition.disableResourceSanitizer.

We've used those sanitizers in internal runtime tests and it proved very useful in
surfacing incorrect tests which resulted in interference between the tests.

All tests have been sanitized.

Closes #4208
This commit is contained in:
Bartek Iwańczuk 2020-03-19 00:25:55 +01:00 • committed by GitHub
parent 070464e2cc
commit 6e2df8c64f
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
28 changed files with 522 additions and 420 deletions
Download patch file Download diff file Expand all files Collapse all files

18
std/node/_fs/_fs_dir_test.ts
View file

@ -71,8 +71,10 @@ test({
name: "Async read returns one file at a time",
async fn() {
const testDir: string = Deno.makeTempDirSync();
Deno.createSync(testDir + "/foo.txt");
Deno.createSync(testDir + "/bar.txt");
const f1 = Deno.createSync(testDir + "/foo.txt");
f1.close();
const f2 = Deno.createSync(testDir + "/bar.txt");
f2.close();
try {
let secondCallback = false;
@ -108,8 +110,10 @@ test({
name: "Sync read returns one file at a time",
fn() {
const testDir: string = Deno.makeTempDirSync();
Deno.createSync(testDir + "/foo.txt");
Deno.createSync(testDir + "/bar.txt");
const f1 = Deno.createSync(testDir + "/foo.txt");
f1.close();
const f2 = Deno.createSync(testDir + "/bar.txt");
f2.close();
try {
const dir: Dir = new Dir(testDir);
@ -135,8 +139,10 @@ test({
name: "Async iteration over existing directory",
async fn() {
const testDir: string = Deno.makeTempDirSync();
Deno.createSync(testDir + "/foo.txt");
Deno.createSync(testDir + "/bar.txt");
const f1 = Deno.createSync(testDir + "/foo.txt");
f1.close();
const f2 = Deno.createSync(testDir + "/bar.txt");
f2.close();
try {
const dir: Dir = new Dir(testDir);