fix(lint): correctly handle old jsx in linter (#25902)

Previously the CLI was incorrectly reporting `React` as unused in a JSX
file that uses the "old" transform.

The LSP was already handling this correctly.

cli/args/mod.rs

@@ -1327,11 +1327,9 @@ impl CliOptions {
       )?;
 
     Ok(deno_lint::linter::LintConfig {
-      default_jsx_factory: transpile_options
+      default_jsx_factory: (!transpile_options.jsx_automatic)
-        .jsx_automatic
         .then(|| transpile_options.jsx_factory.clone()),
-      default_jsx_fragment_factory: transpile_options
+      default_jsx_fragment_factory: (!transpile_options.jsx_automatic)
-        .jsx_automatic
         .then(|| transpile_options.jsx_fragment_factory.clone()),
     })
   }

tests/specs/lint/jsx/__test__.jsonc

@@ -1,15 +1,15 @@
 {
   "steps": [
     {
-      "if": "windows",
+      "args": "lint",
-      "args": "lint main.jsx",
+      "cwd": "./react",
-      "output": "main_windows.out",
+      "output": "react.out",
-      "exitCode": 1
+      "exitCode": 0
     },
     {
-      "if": "unix",
+      "args": "lint",
-      "args": "lint main.jsx",
+      "cwd": "./react-jsx",
-      "output": "main_unix.out",
+      "output": "react-jsx.out",
       "exitCode": 1
     }
   ]

tests/specs/lint/jsx/main.jsx

@@ -1 +0,0 @@
-const data = <div>hello</div>;

tests/specs/lint/jsx/main_windows.out

@@ -1,12 +0,0 @@
-error[no-unused-vars]: `data` is never used
- --> [WILDCARD]lint\jsx\main.jsx:1:7
-  | 
-1 | const data = <div>hello</div>;
-  |       ^^^^
-  = hint: If this is intentional, prefix it with an underscore like `_data`
-
-  docs: https://lint.deno.land/rules/no-unused-vars
-
-
-Found 1 problem
-Checked 1 file

tests/specs/lint/jsx/react-jsx.out

@@ -1,9 +1,9 @@
-error[no-unused-vars]: `data` is never used
+error[no-unused-vars]: `React` is never used
- --> [WILDCARD]lint/jsx/main.jsx:1:7
+ --> [WILDCARD]mod.tsx:1:7
   | 
-1 | const data = <div>hello</div>;
+1 | const React = { createElement() {} };
-  |       ^^^^
+  |       ^^^^^
-  = hint: If this is intentional, prefix it with an underscore like `_data`
+  = hint: If this is intentional, prefix it with an underscore like `_React`
 
   docs: https://lint.deno.land/rules/no-unused-vars
 

tests/specs/lint/jsx/react-jsx/deno.json

@@ -0,0 +1,5 @@
+{
+  "compilerOptions": {
+    "jsx": "react-jsx"
+  }
+}

tests/specs/lint/jsx/react-jsx/mod.tsx

@@ -0,0 +1,3 @@
+const React = { createElement() {} };
+
+const _div = <div />;

tests/specs/lint/jsx/react.out

@@ -0,0 +1 @@
+Checked 1 file

tests/specs/lint/jsx/react/deno.json

@@ -0,0 +1 @@
+{}

tests/specs/lint/jsx/react/mod.tsx

@@ -0,0 +1,3 @@
+const React = { createElement() {} };
+
+const _div = <div />;