language-servers/deno
1
0
Fork 0
mirror of https://github.com/denoland/deno.git synced 2025-10-02 07:01:16 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

fix(lsp): improved cjs tracking (#23374)

Browse source 
Our cjs tracking was a bit broken. It was marking stuff as esm that was
actually cjs leading to type checking errors.
This commit is contained in:
David Sherret 2024-04-15 17:50:52 -04:00 • committed by GitHub
parent 7e4ee02e2e
commit 6f278e5c40
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
16 changed files with 263 additions and 102 deletions
Download patch file Download diff file Expand all files Collapse all files

15
tests/specs/npm/cjs_internal_types_default_export/__test__.jsonc Normal file
View file

@ -0,0 +1,15 @@
{
"tempDir": true,
"envs": {
"DENO_FUTURE": "1"
},
"steps": [{
"commandName": "npm",
"args": "install",
"output": "[WILDCARD]"
}, {
"args": "check main.ts",
"exitCode": 1,
"output": "main.out"
}]
}

5
tests/specs/npm/cjs_internal_types_default_export/main.out Normal file
View file

@ -0,0 +1,5 @@
Check file:///[WILDLINE]/main.ts
error: TS2345 [ERROR]: Argument of type 'string' is not assignable to parameter of type 'number'.
add(1, "test"); // should error
~~~~~~
at file:///[WILDLINE]/main.ts:3:8

3
tests/specs/npm/cjs_internal_types_default_export/main.ts Normal file
View file

@ -0,0 +1,3 @@
import { add } from "@denotest/cjs-internal-types-default-export";
add(1, "test"); // should error

5
tests/specs/npm/cjs_internal_types_default_export/package.json Normal file
View file

@ -0,0 +1,5 @@
{
"dependencies": {
"@denotest/cjs-internal-types-default-export": "*"
}
}