language-servers/deno
1
0
Fork 0
mirror of https://github.com/denoland/deno.git synced 2025-09-26 12:19:12 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

Enable thread pool for blocking ops (#3912)

Browse source
This commit is contained in:
Ryan Dahl 2020-02-07 17:54:44 -05:00 • committed by GitHub
parent 99186dbaa2
commit 724e39f13f
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 4 additions and 11 deletions
Download patch file Download diff file Expand all files Collapse all files

10
cli/ops/dispatch_json.rs
View file

@ -103,15 +103,7 @@ where
if is_sync { if is_sync {
Ok(JsonOp::Sync(f()?)) Ok(JsonOp::Sync(f()?))
} else { } else {
// TODO(ry) use thread pool. let fut = async move { tokio::task::spawn_blocking(f).await.unwrap() };
let fut = crate::tokio_util::spawn_thread(f);
/*
let fut = async move {
tokio::task::spawn_blocking(move || f())
.await
.map_err(ErrBox::from)?
}.boxed_local();
*/
Ok(JsonOp::Async(fut.boxed_local())) Ok(JsonOp::Async(fut.boxed_local()))
} }
} }

5
cli/tokio_util.rs
View file

@ -1,5 +1,4 @@
// Copyright 2018-2020 the Deno authors. All rights reserved. MIT license. // Copyright 2018-2020 the Deno authors. All rights reserved. MIT license.
use futures::Future;
// TODO(ry) rename to run_local ? // TODO(ry) rename to run_local ?
pub fn run_basic<F, R>(future: F) -> R pub fn run_basic<F, R>(future: F) -> R
@ -15,7 +14,9 @@ where
rt.block_on(future) rt.block_on(future)
} }
pub fn spawn_thread<F, R>(f: F) -> impl Future<Output = R> // TODO(ry) maybe replace with tokio::task::spawn_blocking
#[cfg(test)]
pub fn spawn_thread<F, R>(f: F) -> impl std::future::Future<Output = R>
where where
F: 'static + Send + FnOnce() -> R, F: 'static + Send + FnOnce() -> R,
R: 'static + Send, R: 'static + Send,