mirror of
https://github.com/denoland/deno.git
synced 2025-09-24 19:32:30 +00:00
fix(napi): Fix worker threads importing already-loaded NAPI addon (#25245)
Part of #20613. If a node addon is using the legacy `napi_module_register` on ctor approach to module registration, we have to store the registered module so that other threads can load the addon (because `napi_module_register` will only be called once per process).
This commit is contained in:
parent
0e50bb1d4a
commit
7dd861aa36
2 changed files with 58 additions and 0 deletions
|
@ -2,6 +2,7 @@
|
|||
|
||||
import { Buffer } from "node:buffer";
|
||||
import { assert, libSuffix } from "./common.js";
|
||||
import { Worker } from "node:worker_threads";
|
||||
|
||||
const ops = Deno[Deno.internal].core.ops;
|
||||
|
||||
|
@ -13,3 +14,37 @@ Deno.test("ctr initialization (napi_module_register)", {
|
|||
assert(obj != null);
|
||||
assert(typeof obj === "object");
|
||||
});
|
||||
|
||||
Deno.test("ctr initialization by multiple threads (napi_module_register)", {
|
||||
ignore: Deno.build.os == "windows",
|
||||
}, async function () {
|
||||
const path = new URL(`./module.${libSuffix}`, import.meta.url).pathname;
|
||||
const obj = ops.op_napi_open(path, {}, Buffer, reportError);
|
||||
const common = import.meta.resolve("./common.js");
|
||||
assert(obj != null);
|
||||
assert(typeof obj === "object");
|
||||
|
||||
const worker = new Worker(
|
||||
`
|
||||
import { Buffer } from "node:buffer";
|
||||
import { parentPort } from "node:worker_threads";
|
||||
import { assert } from "${common}";
|
||||
|
||||
const ops = Deno[Deno.internal].core.ops;
|
||||
const obj = ops.op_napi_open("${path}", {}, Buffer, reportError);
|
||||
assert(obj != null);
|
||||
assert(typeof obj === "object");
|
||||
parentPort.postMessage("ok");
|
||||
`,
|
||||
{
|
||||
eval: true,
|
||||
},
|
||||
);
|
||||
|
||||
const p = Promise.withResolvers();
|
||||
worker.on("message", (_m) => {
|
||||
p.resolve();
|
||||
});
|
||||
|
||||
await p.promise;
|
||||
});
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue