language-servers/deno
1
0
Fork 0
mirror of https://github.com/denoland/deno.git synced 2025-08-17 09:10:25 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

Fix JavaScript dependencies in bundles. (#4215)

Browse source 
Fixes #4602

We turned off `allowJs` by default, to keep the compiler from grabbing
a bunch of files that it wouldn't actually do anything useful with.  On
the other hand, this caused problems with bundles, where the compiler
needs to gather all the dependencies, including JavaScript ones.  This
fixes this so that when we are bundling, we analyse JavaScript imports
in the compiler.
This commit is contained in:
Kitson Kelly 2020-03-03 08:18:27 +11:00 • committed by GitHub
parent a3c3a56ff7
commit 83d902a780
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
6 changed files with 84 additions and 25 deletions
Download patch file Download diff file Expand all files Collapse all files

9
cli/js/compiler_api_test.ts
View file

@ -135,6 +135,15 @@ test(async function bundleApiConfig() {
assert(!actual.includes(`random`));
});
test(async function bundleApiJsModules() {
const [diagnostics, actual] = await bundle("/foo.js", {
"/foo.js": `export * from "./bar.js";\n`,
"/bar.js": `export const bar = "bar";\n`
});
assert(diagnostics == null);
assert(actual.includes(`System.register("bar",`));
});
test(async function diagnosticsTest() {
const [diagnostics] = await compile("/foo.ts", {
"/foo.ts": `document.getElementById("foo");`