fix(check): move types not found error to tsc diagnostic (#31509)

Closes https://github.com/denoland/deno/issues/31352

cli/graph_util.rs

@@ -297,9 +297,9 @@ pub fn resolution_error_for_tsc_diagnostic(
       | NodeJsErrorCode::ERR_UNSUPPORTED_ESM_URL_SCHEME
       | NodeJsErrorCode::ERR_INVALID_FILE_URL_PATH
       | NodeJsErrorCode::ERR_PACKAGE_IMPORT_NOT_DEFINED
-      | NodeJsErrorCode::ERR_PACKAGE_PATH_NOT_EXPORTED
-      | NodeJsErrorCode::ERR_TYPES_NOT_FOUND => false,
+      | NodeJsErrorCode::ERR_PACKAGE_PATH_NOT_EXPORTED => false,
       NodeJsErrorCode::ERR_MODULE_NOT_FOUND
+      | NodeJsErrorCode::ERR_TYPES_NOT_FOUND
       | NodeJsErrorCode::ERR_UNKNOWN_BUILTIN_MODULE => true,
     }
   }

tests/specs/check/req_types_and_execution_not_found/__test__.jsonc

@@ -0,0 +1,5 @@
+{
+  "args": "check main.ts",
+  "output": "check.out",
+  "exitCode": 1
+}

tests/specs/check/req_types_and_execution_not_found/check.out

@@ -0,0 +1,5 @@
+Check main.ts
+TS2307 [ERROR]: Cannot find module 'package'.
+    at file:///[WILDLINE]/main.ts:1:22
+
+error: Type checking failed.

tests/specs/check/req_types_and_execution_not_found/deno.json

@@ -0,0 +1,6 @@
+{
+  "nodeModulesDir": "manual",
+  "imports": {
+    "package": "npm:package"
+  }
+}

tests/specs/check/req_types_and_execution_not_found/main.ts

@@ -0,0 +1,2 @@
+import * as pkg from "package";
+console.log(pkg);

tests/specs/check/req_types_and_execution_not_found/node_modules/package/package.json

@@ -0,0 +1,4 @@
+{
+  "name": "package",
+  "version": "1.0.0"
+}

tests/specs/npm/file_specifier/package-b/index.d.ts

@@ -0,0 +1 @@
+export function add(a: number, b: number): number;