language-servers/deno
1
0
Fork 0
mirror of https://github.com/denoland/deno.git synced 2025-09-27 12:49:10 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

refactor: rewrite testPerm into unitTest (#4231)

Browse source 
Rewrite "testPerm" helper function used for testing of internal 
runtime code. It's been renamed to "unitTest" and provides API that
is extensible in the future by accepting optional "UnitTestOptions" 
argument. "test" helper was also removed and replaced by
overloaded version of "unitTest" that takes only function argument.

"UnitTestOptions" currently supports "perms" and "skip"
options, where former works exactly as first argument to "testPerm"
did, while the latter allows to conditionally skip tests.
This commit is contained in:
Bartek Iwańczuk 2020-03-04 17:31:14 +01:00 • committed by GitHub
parent 30682cf74f
commit 8d96dffa41
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
60 changed files with 2389 additions and 2047 deletions
Download patch file Download diff file Expand all files Collapse all files

16
cli/js/read_file_test.ts
View file

@ -1,7 +1,7 @@
// Copyright 2018-2020 the Deno authors. All rights reserved. MIT license.
import { testPerm, assert, assertEquals } from "./test_util.ts";
import { unitTest, assert, assertEquals } from "./test_util.ts";
testPerm({ read: true }, function readFileSyncSuccess(): void {
unitTest({ perms: { read: true } }, function readFileSyncSuccess(): void {
const data = Deno.readFileSync("cli/tests/fixture.json");
assert(data.byteLength > 0);
const decoder = new TextDecoder("utf-8");
@ -10,7 +10,7 @@ testPerm({ read: true }, function readFileSyncSuccess(): void {
assertEquals(pkg.name, "deno");
});
testPerm({ read: false }, function readFileSyncPerm(): void {
unitTest({ perms: { read: false } }, function readFileSyncPerm(): void {
let caughtError = false;
try {
Deno.readFileSync("cli/tests/fixture.json");
@ -21,7 +21,7 @@ testPerm({ read: false }, function readFileSyncPerm(): void {
assert(caughtError);
});
testPerm({ read: true }, function readFileSyncNotFound(): void {
unitTest({ perms: { read: true } }, function readFileSyncNotFound(): void {
let caughtError = false;
let data;
try {
@ -34,7 +34,9 @@ testPerm({ read: true }, function readFileSyncNotFound(): void {
assert(data === undefined);
});
testPerm({ read: true }, async function readFileSuccess(): Promise<void> {
unitTest({ perms: { read: true } }, async function readFileSuccess(): Promise<
void
> {
const data = await Deno.readFile("cli/tests/fixture.json");
assert(data.byteLength > 0);
const decoder = new TextDecoder("utf-8");
@ -43,7 +45,9 @@ testPerm({ read: true }, async function readFileSuccess(): Promise<void> {
assertEquals(pkg.name, "deno");
});
testPerm({ read: false }, async function readFilePerm(): Promise<void> {
unitTest({ perms: { read: false } }, async function readFilePerm(): Promise<
void
> {
let caughtError = false;
try {
await Deno.readFile("cli/tests/fixture.json");