mirror of
https://github.com/denoland/deno.git
synced 2025-08-04 19:08:15 +00:00
refactor(ops): ops2 supports result in fast path (#19603)
Implements `Result` in fast-calls. Note that the approach here is slightly different. Rather than store the last result in the `OpState`, we put it into the `OpCtx` which saves us a lookup and lock in the error case. We do not have to lock this field as it's guaranteed only one runtime and thread can ever access it. The fastcall path for many ops can avoid doing a great deal of work, even for `Result` return values. In the previous iteration of `ops`, all `Result`-returning functions would fetch and lock the `OpState`, regardless of whether it was used or not.
This commit is contained in:
parent
3fe44a50c3
commit
8fe9b8a4cc
13 changed files with 551 additions and 221 deletions
|
@ -50,7 +50,7 @@ pub enum V8MappingError {
|
|||
}
|
||||
|
||||
#[derive(Default)]
|
||||
struct MacroConfig {
|
||||
pub(crate) struct MacroConfig {
|
||||
pub core: bool,
|
||||
pub fast: bool,
|
||||
}
|
||||
|
@ -135,6 +135,8 @@ fn generate_op2(
|
|||
let opctx = Ident::new("opctx", Span::call_site());
|
||||
let slow_function = Ident::new("slow_function", Span::call_site());
|
||||
let fast_function = Ident::new("fast_function", Span::call_site());
|
||||
let fast_api_callback_options =
|
||||
Ident::new("fast_api_callback_options", Span::call_site());
|
||||
|
||||
let deno_core = if config.core {
|
||||
syn2::parse_str::<Path>("crate")
|
||||
|
@ -151,6 +153,7 @@ fn generate_op2(
|
|||
scope,
|
||||
info,
|
||||
opctx,
|
||||
fast_api_callback_options,
|
||||
deno_core,
|
||||
result,
|
||||
retval,
|
||||
|
@ -161,10 +164,14 @@ fn generate_op2(
|
|||
needs_scope: false,
|
||||
needs_opctx: false,
|
||||
needs_opstate: false,
|
||||
needs_fast_opctx: false,
|
||||
needs_fast_api_callback_options: false,
|
||||
};
|
||||
|
||||
let name = func.sig.ident;
|
||||
let slow_fn = generate_dispatch_slow(&mut generator_state, &signature)?;
|
||||
|
||||
let slow_fn =
|
||||
generate_dispatch_slow(&config, &mut generator_state, &signature)?;
|
||||
let (fast_definition, fast_fn) =
|
||||
match generate_dispatch_fast(&mut generator_state, &signature)? {
|
||||
Some((fast_definition, fast_fn)) => {
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue