language-servers/deno
1
0
Fork 0
mirror of https://github.com/denoland/deno.git synced 2025-08-04 10:59:13 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

fix(ext/fetch): new Request should soft clone (#16869)

Browse source 
Previously the inner request object of the original and the new request
were the same, causing the requests to be entangled and mutable changes
to one to be visible to the other. This fixes that.
This commit is contained in:
Luca Casonato 2022-12-06 09:39:04 +01:00 • committed by GitHub
parent 3973ceb634
commit 923370f18f
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 33 additions and 12 deletions
Download patch file Download diff file Expand all files Collapse all files

29
cli/tests/unit/fetch_test.ts
View file

@ -1776,9 +1776,7 @@ Deno.test(
Deno.test(
{ permissions: { net: true } },
async function fetchBlobUrl(): Promise<
void
> {
async function fetchBlobUrl(): Promise<void> {
const blob = new Blob(["ok"], { type: "text/plain" });
const url = URL.createObjectURL(blob);
const res = await fetch(url);
@ -1805,3 +1803,28 @@ Deno.test(
await promise;
},
);
Deno.test(
{ permissions: { net: true } },
async function fetchConstructorClones() {
const req = new Request("https://example.com", {
method: "POST",
body: "foo",
});
assertEquals(await req.text(), "foo");
await assertRejects(() => req.text());
const req2 = new Request(req, { method: "PUT", body: "bar" }); // should not have any impact on req
await assertRejects(() => req.text());
assertEquals(await req2.text(), "bar");
assertEquals(req.method, "POST");
assertEquals(req2.method, "PUT");
assertEquals(req.headers.get("x-foo"), null);
assertEquals(req2.headers.get("x-foo"), null);
req2.headers.set("x-foo", "bar"); // should not have any impact on req
assertEquals(req.headers.get("x-foo"), null);
assertEquals(req2.headers.get("x-foo"), "bar");
},
);