language-servers/deno
1
0
Fork 0
mirror of https://github.com/denoland/deno.git synced 2025-08-04 10:59:13 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

fix(ext/napi): napi_is_buffer tests for ArrayBufferView (#27956)

Browse source 
use correct type check

Fixes: https://github.com/denoland/deno/issues/27951
This commit is contained in:
snek 2025-02-04 15:30:40 +01:00 • committed by GitHub
parent c2832d70a1
commit 98339cf327
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 26 additions and 11 deletions
Download patch file Download diff file Expand all files Collapse all files

12
ext/napi/node_api.rs
View file

@ -400,18 +400,8 @@ fn napi_is_buffer(
check_arg!(env, value);
check_arg!(env, result);
let buffer_constructor =
v8::Local::new(&mut env.scope(), &env.buffer_constructor);
let Some(is_buffer) = value
.unwrap()
.instance_of(&mut env.scope(), buffer_constructor.into())
else {
return napi_set_last_error(env, napi_generic_failure);
};
unsafe {
*result = is_buffer;
*result = value.unwrap().is_array_buffer_view();
}
napi_clear_last_error(env)