language-servers/deno
1
0
Fork 0
mirror of https://github.com/denoland/deno.git synced 2025-09-28 13:14:48 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

chore: align fetch to spec (#10203)

Browse source 
This commit aligns the `fetch` API and the `Request` / `Response`
classes belonging to it to the spec. This commit enables all the
relevant `fetch` WPT tests. Spec compliance is now at around 90%.

Performance is essentially identical now (within 1% of 1.9.0).
This commit is contained in:
Luca Casonato 2021-04-20 14:47:22 +02:00 • committed by GitHub
parent 115197ffb0
commit 9e6cd91014
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
30 changed files with 2235 additions and 1384 deletions
Download patch file Download diff file Expand all files Collapse all files

35
op_crates/fetch/lib.rs
View file

@ -70,13 +70,29 @@ pub fn init(isolate: &mut JsRuntime) {
"deno:op_crates/fetch/21_formdata.js",
include_str!("21_formdata.js"),
),
(
"deno:op_crates/fetch/22_body.js",
include_str!("22_body.js"),
),
(
"deno:op_crates/fetch/22_http_client.js",
include_str!("22_http_client.js"),
),
(
"deno:op_crates/fetch/23_request.js",
include_str!("23_request.js"),
),
(
"deno:op_crates/fetch/23_response.js",
include_str!("23_response.js"),
),
(
"deno:op_crates/fetch/26_fetch.js",
include_str!("26_fetch.js"),
),
];
for (url, source_code) in files {
isolate.execute(url, source_code).unwrap();
isolate.execute(url, source_code).expect(url);
}
}
@ -110,9 +126,8 @@ pub fn get_declaration() -> PathBuf {
#[derive(Deserialize)]
#[serde(rename_all = "camelCase")]
pub struct FetchArgs {
method: Option<String>,
method: String,
url: String,
base_url: Option<String>,
headers: Vec<(String, String)>,
client_rid: Option<u32>,
has_body: bool,
@ -144,18 +159,8 @@ where
client.clone()
};
let method = match args.method {
Some(method_str) => Method::from_bytes(method_str.as_bytes())?,
None => Method::GET,
};
let base_url = match args.base_url {
Some(base_url) => Some(Url::parse(&base_url)?),
_ => None,
};
let url = Url::options()
.base_url(base_url.as_ref())
.parse(&args.url)?;
let method = Method::from_bytes(args.method.as_bytes())?;
let url = Url::parse(&args.url)?;
// Check scheme before asking for net permission
let scheme = url.scheme();