language-servers/deno
1
0
Fork 0
mirror of https://github.com/denoland/deno.git synced 2025-09-26 12:19:12 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

fix: Validate all tests included in unit_tests.ts (#3879)

Browse source
This commit is contained in:
Chris Knight 2020-02-05 08:23:23 +00:00 • committed by GitHub
parent 55ea854671
commit a04e7270cd
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 46 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

32
cli/js/test_util.ts
View file

@ -296,3 +296,35 @@ testPerm({ read: true }, async function parsingUnitTestOutput(): Promise<void> {
assertEquals(result.actual, undefined);
assertEquals(result.expected, undefined);
});
/*
* Ensure all unit test files (e.g. xxx_test.ts) are present as imports in
* cli/js/unit_tests.ts as it is easy to miss this out
*/
testPerm(
{ read: true },
async function assertAllUnitTestFilesImported(): Promise<void> {
const directoryTestFiles = Deno.readDirSync("./cli/js")
.map(k => k.name)
.filter(file => file.endsWith("_test.ts"));
const unitTestsFile: Uint8Array = Deno.readFileSync(
"./cli/js/unit_tests.ts"
);
const importLines = new TextDecoder("utf-8")
.decode(unitTestsFile)
.split("\n")
.filter(line => line.startsWith("import") && line.includes("_test.ts"));
const importedTestFiles = importLines.map(
relativeFilePath => relativeFilePath.match(/\/([^\/]+)";/)[1]
);
directoryTestFiles.forEach(dirFile => {
if (!importedTestFiles.includes(dirFile)) {
throw new Error(
"cil/js/unit_tests.ts is missing import of test file: cli/js/" +
dirFile
);
}
});
}
);