language-servers/deno
1
0
Fork 0
mirror of https://github.com/denoland/deno.git synced 2025-07-28 23:53:53 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

Add Deno global namespace (#1748)

Browse source 
Resolves #1705

This PR adds the Deno APIs as a global namespace named `Deno`. For backwards
compatibility, the ability to `import * from "deno"` is preserved. I have tried
to convert every test and internal code the references the module to use the
namespace instead, but because I didn't break compatibility I am not sure.

On the REPL, `deno` no longer exists, replaced only with `Deno` to align with
the regular runtime.

The runtime type library includes both the namespace and module. This means it
duplicates the whole type information. When we remove the functionality from the
runtime, it will be a one line change to the library generator to remove the
module definition from the type library.

I marked a `TODO` in a couple places where to remove the `"deno"` module, but
there are additional places I know I didn't mark.
This commit is contained in:
Kitson Kelly 2019-02-13 02:08:56 +11:00 • committed by Ryan Dahl
parent 1e5e091cb0
commit a21a5ad2fa
66 changed files with 677 additions and 652 deletions
Download patch file Download diff file Expand all files Collapse all files

26
js/read_dir_test.ts
View file

@ -1,7 +1,7 @@
// Copyright 2018-2019 the Deno authors. All rights reserved. MIT license.
import { testPerm, assert, assertEqual } from "./test_util.ts";
import * as deno from "deno";
import { FileInfo } from "deno";
type FileInfo = Deno.FileInfo;
function assertSameContent(files: FileInfo[]) {
let counter = 0;
@ -14,7 +14,7 @@ function assertSameContent(files: FileInfo[]) {
if (file.name === "002_hello.ts") {
assertEqual(file.path, `tests/${file.name}`);
assertEqual(file.mode!, deno.statSync(`tests/${file.name}`).mode!);
assertEqual(file.mode!, Deno.statSync(`tests/${file.name}`).mode!);
counter++;
}
}
@ -23,17 +23,17 @@ function assertSameContent(files: FileInfo[]) {
}
testPerm({ read: true }, function readDirSyncSuccess() {
const files = deno.readDirSync("tests/");
const files = Deno.readDirSync("tests/");
assertSameContent(files);
});
testPerm({ read: false }, function readDirSyncPerm() {
let caughtError = false;
try {
const files = deno.readDirSync("tests/");
const files = Deno.readDirSync("tests/");
} catch (e) {
caughtError = true;
assertEqual(e.kind, deno.ErrorKind.PermissionDenied);
assertEqual(e.kind, Deno.ErrorKind.PermissionDenied);
assertEqual(e.name, "PermissionDenied");
}
assert(caughtError);
@ -44,10 +44,10 @@ testPerm({ read: true }, function readDirSyncNotDir() {
let src;
try {
src = deno.readDirSync("package.json");
src = Deno.readDirSync("package.json");
} catch (err) {
caughtError = true;
assertEqual(err.kind, deno.ErrorKind.Other);
assertEqual(err.kind, Deno.ErrorKind.Other);
}
assert(caughtError);
assertEqual(src, undefined);
@ -58,27 +58,27 @@ testPerm({ read: true }, function readDirSyncNotFound() {
let src;
try {
src = deno.readDirSync("bad_dir_name");
src = Deno.readDirSync("bad_dir_name");
} catch (err) {
caughtError = true;
assertEqual(err.kind, deno.ErrorKind.NotFound);
assertEqual(err.kind, Deno.ErrorKind.NotFound);
}
assert(caughtError);
assertEqual(src, undefined);
});
testPerm({ read: true }, async function readDirSuccess() {
const files = await deno.readDir("tests/");
const files = await Deno.readDir("tests/");
assertSameContent(files);
});
testPerm({ read: false }, async function readDirPerm() {
let caughtError = false;
try {
const files = await deno.readDir("tests/");
const files = await Deno.readDir("tests/");
} catch (e) {
caughtError = true;
assertEqual(e.kind, deno.ErrorKind.PermissionDenied);
assertEqual(e.kind, Deno.ErrorKind.PermissionDenied);
assertEqual(e.name, "PermissionDenied");
}
assert(caughtError);