mirror of
https://github.com/denoland/deno.git
synced 2025-09-26 12:19:12 +00:00
fix(cli): Respect implied BYONM from DENO_FUTURE in deno task
(#24652)
Regression from
04f9db5b22
Originally I thought to fix the issue in the PR we needed to explicitly
pass through the `node-modules-dir` flag, but after applying the correct
fix that david pointed out (setting `NPM_PROCESS_STATE`) that wasn't
necessary (or correct).
We had a test for deno task with BYONM, but it only tested with
`"unstable": ["byonm"]` in deno.json, so it didn't catch this.
This commit is contained in:
parent
f6c7c13764
commit
a4c76add56
4 changed files with 67 additions and 30 deletions
|
@ -132,6 +132,19 @@
|
|||
"output": "no_deno_json.out"
|
||||
}
|
||||
]
|
||||
},
|
||||
"lifecycle_scripts_no_deno_json_conflicting_bin": {
|
||||
"tempDir": true,
|
||||
"steps": [
|
||||
{
|
||||
"args": ["eval", "Deno.removeSync('deno.json')"],
|
||||
"output": ""
|
||||
},
|
||||
{
|
||||
"args": "cache --allow-scripts --node-modules-dir=true conflicting_bin.js",
|
||||
"output": "conflicting_bin.out"
|
||||
}
|
||||
]
|
||||
}
|
||||
}
|
||||
}
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue