chore(runtime): internalize pipe fd for ext/node (#21570)

Signed-off-by: Divy Srivastava <dj.srivastava23@gmail.com>
This commit is contained in:
Divy Srivastava 2023-12-30 11:02:30 +05:30 committed by GitHub
parent 4de9ddcf21
commit a7b21760fc
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 12 additions and 9 deletions

View file

@ -1,6 +1,6 @@
// Copyright 2018-2023 the Deno authors. All rights reserved. MIT license.
import { core, primordials } from "ext:core/mod.js";
import { core, internals, primordials } from "ext:core/mod.js";
const ops = core.ops;
const {
ArrayPrototypeMap,
@ -204,16 +204,16 @@ function collectOutput(readableStream) {
return readableStreamCollectIntoUint8Array(readableStream);
}
const _pipeFd = Symbol("[[pipeFd]]");
internals.getPipeFd = (process) => process[_pipeFd];
class ChildProcess {
#rid;
#waitPromise;
#waitComplete = false;
#pipeFd;
// internal, used by ext/node
get _pipeFd() {
return this.#pipeFd;
}
[_pipeFd];
#pid;
get pid() {
@ -259,7 +259,7 @@ class ChildProcess {
this.#rid = rid;
this.#pid = pid;
this.#pipeFd = pipeFd;
this[_pipeFd] = pipeFd;
if (stdinRid !== null) {
this.#stdin = writableStreamForRid(stdinRid);