language-servers/deno
1
0
Fork 0
mirror of https://github.com/denoland/deno.git synced 2025-08-30 23:38:03 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

BREAKING(net): remove Deno.{Conn,TlsConn,TcpConn,UnixConn}.prototype.rid (#25446)

Browse source 
Towards #22079

---------

Signed-off-by: Asher Gomez <ashersaupingomez@gmail.com>
This commit is contained in:
Asher Gomez 2024-09-07 09:01:36 +10:00 • committed by GitHub
parent 5bac4075c3
commit a9ed06b832
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
7 changed files with 1 additions and 122 deletions
Download patch file Download diff file Expand all files Collapse all files

34
ext/net/01_net.js
View file

@ -101,13 +101,6 @@ class Conn {
#writable;
constructor(rid, remoteAddr, localAddr) {
if (internals.future) {
ObjectDefineProperty(this, "rid", {
__proto__: null,
enumerable: false,
value: undefined,
});
}
ObjectDefineProperty(this, internalRidSymbol, {
__proto__: null,
enumerable: false,
@ -118,15 +111,6 @@ class Conn {
this.#localAddr = localAddr;
}
get rid() {
internals.warnOnDeprecatedApi(
"Deno.Conn.rid",
new Error().stack,
"Use `Deno.Conn` instance methods instead.",
);
return this.#rid;
}
get remoteAddr() {
return this.#remoteAddr;
}
@ -223,15 +207,6 @@ class TcpConn extends Conn {
this.#rid = rid;
}
get rid() {
internals.warnOnDeprecatedApi(
"Deno.TcpConn.rid",
new Error().stack,
"Use `Deno.TcpConn` instance methods instead.",
);
return this.#rid;
}
setNoDelay(noDelay = true) {
return op_set_nodelay(this.#rid, noDelay);
}
@ -253,15 +228,6 @@ class UnixConn extends Conn {
});
this.#rid = rid;
}
get rid() {
internals.warnOnDeprecatedApi(
"Deno.UnixConn.rid",
new Error().stack,
"Use `Deno.UnixConn` instance methods instead.",
);
return this.#rid;
}
}
class Listener {