language-servers/deno
1
0
Fork 0
mirror of https://github.com/denoland/deno.git synced 2025-09-28 13:14:48 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

perf(ext/websocket): use opAsync2 to avoid spread deopt (#18525)

Browse source 
This commit adds a new core API `opAsync2` to call an async op with
atmost 2 arguments. Spread argument iterators has a pretty big perf hit
when calling ops.

| name | avg msg/sec/core |
| --- | --- |
| 1.32.1 | `127820.750000` |
| #18506 | `140079.000000` |
| #18506 + #18509 | `150104.250000` |
| #18506 + #18509 + this | `157340.000000` |
This commit is contained in:
Divy Srivastava 2023-03-31 21:28:21 +05:30 • committed by GitHub
parent feab94ff51
commit aa9b94a80e
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
8 changed files with 31 additions and 18 deletions
Download patch file Download diff file Expand all files Collapse all files

4
core/examples/http_bench_json_ops/http_bench_json_ops.js
View file

@ -3,7 +3,7 @@
// then write this fixed 'responseBuf'. The point of this benchmark is to
// exercise the event loop in a simple yet semi-realistic way.
const { ops, opAsync } = Deno.core;
const { ops, opAsync, opAsync2 } = Deno.core;
const requestBuf = new Uint8Array(64 * 1024);
const responseBuf = new Uint8Array(
@ -23,7 +23,7 @@ function accept(serverRid) {
}
function read(serverRid, buf) {
return opAsync("op_read_socket", serverRid, buf);
return opAsync2("op_read_socket", serverRid, buf);
}
async function serve(rid) {