language-servers/deno
1
0
Fork 0
mirror of https://github.com/denoland/deno.git synced 2025-09-26 12:19:12 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

refactor: remove Deno.core (#16881)

Browse source 
This commit removes "Deno.core" namespace. It is strictly private API
that has no stability guarantees, we were supposed to remove it long time ago.

Co-authored-by: Yoshiya Hinosawa <stibium121@gmail.com>
This commit is contained in:
Bartek Iwańczuk 2023-01-24 18:54:10 +01:00 • committed by GitHub
parent 1084027d50
commit abd9610530
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
43 changed files with 104 additions and 89 deletions
Download patch file Download diff file Expand all files Collapse all files

18
runtime/js/99_main.js
View file

@ -485,8 +485,14 @@ delete Intl.v8BreakIterator;
},
});
const finalDenoNs = {
// FIXME(bartlomieju): temporarily add whole `Deno.core` to
// `Deno[Deno.internal]` namespace. It should be removed and only necessary
// methods should be left there.
ObjectAssign(internals, {
core,
});
const finalDenoNs = {
internal: internalSymbol,
[internalSymbol]: internals,
resources: core.resources,
@ -524,7 +530,6 @@ delete Intl.v8BreakIterator;
// Setup `Deno` global - we're actually overriding already existing global
// `Deno` with `Deno` namespace from "./deno.ts".
ObjectDefineProperty(globalThis, "Deno", util.readOnly(finalDenoNs));
ObjectFreeze(globalThis.Deno.core);
util.log("args", runtimeOptions.args);
}
@ -625,8 +630,14 @@ delete Intl.v8BreakIterator;
},
});
const finalDenoNs = {
// FIXME(bartlomieju): temporarily add whole `Deno.core` to
// `Deno[Deno.internal]` namespace. It should be removed and only necessary
// methods should be left there.
ObjectAssign(internals, {
core,
});
const finalDenoNs = {
internal: internalSymbol,
[internalSymbol]: internals,
resources: core.resources,
@ -660,7 +671,6 @@ delete Intl.v8BreakIterator;
// Setup `Deno` global - we're actually overriding already
// existing global `Deno` with `Deno` namespace from "./deno.ts".
ObjectDefineProperty(globalThis, "Deno", util.readOnly(finalDenoNs));
ObjectFreeze(globalThis.Deno.core);
}
ObjectDefineProperties(globalThis, {