language-servers/deno
1
0
Fork 0
mirror of https://github.com/denoland/deno.git synced 2025-08-04 19:08:15 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

perf(ext/fetch): Use the WebIDL conversion to DOMString rather than USVString for Response constructor (#12201)

Browse source
This commit is contained in:
Luis Malheiro 2021-09-25 10:30:31 -03:00 • committed by GitHub
parent 09f2cdbc72
commit b095157c1d
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
5 changed files with 48 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

11
ext/fetch/22_body.js
View file

@ -372,7 +372,7 @@
return { body, contentType };
}
webidl.converters["BodyInit"] = (V, opts) => {
webidl.converters["BodyInit_DOMString"] = (V, opts) => {
// Union for (ReadableStream or Blob or ArrayBufferView or ArrayBuffer or FormData or URLSearchParams or USVString)
if (V instanceof ReadableStream) {
// TODO(lucacasonato): ReadableStream is not branded
@ -393,10 +393,13 @@
return webidl.converters["ArrayBufferView"](V, opts);
}
}
return webidl.converters["USVString"](V, opts);
// BodyInit conversion is passed to extractBody(), which calls core.encode().
// core.encode() will UTF-8 encode strings with replacement, being equivalent to the USV normalization.
// Therefore we can convert to DOMString instead of USVString and avoid a costly redundant conversion.
return webidl.converters["DOMString"](V, opts);
};
webidl.converters["BodyInit?"] = webidl.createNullableConverter(
webidl.converters["BodyInit"],
webidl.converters["BodyInit_DOMString?"] = webidl.createNullableConverter(
webidl.converters["BodyInit_DOMString"],
);
window.__bootstrap.fetchBody = { mixinBody, InnerBody, extractBody };