language-servers/deno
1
0
Fork 0
mirror of https://github.com/denoland/deno.git synced 2025-07-23 13:15:16 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

feat(task): support scripts in package.json (#17887)

Browse source 
This is a super basic initial implementation. We don't create a
`node_modules/.bin` folder at the moment and add it to the PATH like we
should which is necessary to make command name resolution in the
subprocess work properly (ex. you run a script that launches another
script that then tries to launch an "npx command"... this won't work
atm).

Closes #17492
This commit is contained in:
David Sherret 2023-02-22 22:45:35 -05:00 • committed by GitHub
parent cc8e4a00aa
commit b15f9e60a0
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
45 changed files with 561 additions and 197 deletions
Download patch file Download diff file Expand all files Collapse all files

16
cli/npm/resolvers/mod.rs
View file

@ -150,25 +150,23 @@ impl NpmPackageResolver {
/// Resolves an npm package folder path from a Deno module.
pub fn resolve_package_folder_from_deno_module(
&self,
package_id: &NpmPackageNv,
pkg_nv: &NpmPackageNv,
) -> Result<PathBuf, AnyError> {
let node_id = self
.resolution
.resolve_pkg_id_from_deno_module(package_id)?;
self.resolve_pkg_folder_from_deno_module_at_node_id(&node_id)
let pkg_id = self.resolution.resolve_pkg_id_from_deno_module(pkg_nv)?;
self.resolve_pkg_folder_from_deno_module_at_pkg_id(&pkg_id)
}
fn resolve_pkg_folder_from_deno_module_at_node_id(
fn resolve_pkg_folder_from_deno_module_at_pkg_id(
&self,
package_id: &NpmPackageId,
pkg_id: &NpmPackageId,
) -> Result<PathBuf, AnyError> {
let path = self
.fs_resolver
.resolve_package_folder_from_deno_module(package_id)?;
.resolve_package_folder_from_deno_module(pkg_id)?;
let path = canonicalize_path_maybe_not_exists(&path)?;
log::debug!(
"Resolved package folder of {} to {}",
package_id.as_serialized(),
pkg_id.as_serialized(),
path.display()
);
Ok(path)