language-servers/deno
1
0
Fork 0
mirror of https://github.com/denoland/deno.git synced 2025-09-24 19:32:30 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

fix(ext/node): don't rely on Deno.env to read NODE_DEBUG (#23694)

Browse source 
This patch allows implementors to use ext/node without
the need to implement Deno.env API.

Closes https://github.com/denoland/deno/issues/23687
This commit is contained in:
Satya Rohith 2024-05-05 19:46:02 +05:30 • committed by GitHub
parent d527b63575
commit b2628e4a06
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
6 changed files with 45 additions and 25 deletions
Download patch file Download diff file Expand all files Collapse all files

40
runtime/js/99_main.js
View file

@ -706,12 +706,13 @@ function bootstrapMainRuntime(runtimeOptions, warmup = false) {
3: inspectFlag,
5: hasNodeModulesDir,
6: argv0,
7: shouldDisableDeprecatedApiWarning,
8: shouldUseVerboseDeprecatedApiWarning,
9: future,
10: mode,
11: servePort,
12: serveHost,
7: nodeDebug,
8: shouldDisableDeprecatedApiWarning,
9: shouldUseVerboseDeprecatedApiWarning,
10: future,
11: mode,
12: servePort,
13: serveHost,
} = runtimeOptions;
if (mode === executionModes.run || mode === executionModes.serve) {
@ -859,7 +860,12 @@ function bootstrapMainRuntime(runtimeOptions, warmup = false) {
ObjectDefineProperty(globalThis, "Deno", core.propReadOnly(finalDenoNs));
if (nodeBootstrap) {
nodeBootstrap(hasNodeModulesDir, argv0, /* runningOnMainThread */ true);
nodeBootstrap({
usesLocalNodeModulesDir: hasNodeModulesDir,
runningOnMainThread: true,
argv0,
nodeDebug,
});
}
if (future) {
delete globalThis.window;
@ -917,9 +923,10 @@ function bootstrapWorkerRuntime(
4: enableTestingFeaturesFlag,
5: hasNodeModulesDir,
6: argv0,
7: shouldDisableDeprecatedApiWarning,
8: shouldUseVerboseDeprecatedApiWarning,
9: future,
7: nodeDebug,
8: shouldDisableDeprecatedApiWarning,
9: shouldUseVerboseDeprecatedApiWarning,
10: future,
} = runtimeOptions;
// TODO(iuioiua): remove in Deno v2. This allows us to dynamically delete
@ -1016,13 +1023,14 @@ function bootstrapWorkerRuntime(
: undefined;
if (nodeBootstrap) {
nodeBootstrap(
hasNodeModulesDir,
nodeBootstrap({
usesLocalNodeModulesDir: hasNodeModulesDir,
runningOnMainThread: false,
argv0,
/* runningOnMainThread */ false,
workerId,
workerMetadata,
);
maybeWorkerMetadata: workerMetadata,
nodeDebug,
});
}
if (future) {
@ -1097,4 +1105,4 @@ bootstrapWorkerRuntime(
undefined,
true,
);
nodeBootstrap(undefined, undefined, undefined, undefined, undefined, true);
nodeBootstrap({ warmup: true });